Skip to content

Go: Update to 1.27 - #22042

Open
jketema wants to merge 8 commits into
mainfrom
jketema/go-1.27
Open

Go: Update to 1.27#22042
jketema wants to merge 8 commits into
mainfrom
jketema/go-1.27

Conversation

@jketema

@jketema jketema commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Note that all tests failing here pass on the internal PR.

@github-actions github-actions Bot added the Go label Jun 24, 2026
@jketema jketema added the depends on internal PR This PR should only be merged in sync with an internal Semmle PR label Jun 24, 2026
@jketema
jketema force-pushed the jketema/go-1.27 branch 3 times, most recently from f0842b5 to 91e1d28 Compare June 30, 2026 15:20

@owen-mc owen-mc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass review.

Comment thread go/extractor/extractor.go Outdated
Comment thread go/extractor/extractor.go Outdated
Comment thread go/extractor/extractor.go Outdated
Comment thread go/extractor/extractor.go Outdated
Comment thread go/ql/test/library-tests/semmle/go/Function/genericMethods.go Outdated
@jketema
jketema force-pushed the jketema/go-1.27 branch 7 times, most recently from ecdd643 to 48c57e3 Compare July 14, 2026 12:10
@jketema
jketema marked this pull request as ready for review August 19, 2026 21:53
@jketema
jketema requested review from a team as code owners August 19, 2026 21:53
Copilot AI balanced review requested due to automatic review settings August 19, 2026 21:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates CodeQL’s Go support to Go 1.27, including generic method extraction.

Changes:

  • Updates SDK, toolchain, CI, and supported-version documentation.
  • Handles Go 1.27 generic method type parameters and receivers.
  • Adds generic method fixtures and expected results.
Show a summary per file
File Description
MODULE.bazel Pins Go SDK 1.27.0.
go/extractor/go.mod Updates Go and toolchain versions.
go/extractor/extractor.go Handles instantiated generic method parameters.
go/extractor/trap/labels.go Resolves originating receiver objects.
go/extractor/autobuilder/build-environment.go Raises maximum supported Go version.
go/extractor/toolchain/toolchain_test.go Applies Go 1.27 formatting.
go/actions/test/action.yml Runs tests with Go 1.27.0.
go/ql/test/library-tests/semmle/go/Function/go.mod Enables Go 1.27 test syntax.
go/ql/test/library-tests/semmle/go/Function/genericMethods.go Adds generic method fixtures.
go/ql/test/library-tests/semmle/go/Function/TypeParamType.expected Updates type-parameter results.
go/ql/test/library-tests/semmle/go/Function/getTypeParameter.expected Updates declaration results.
go/ql/test/library-tests/semmle/go/Function/getParameter.expected Updates method parameter results.
go/ql/test/library-tests/semmle/go/Function/GenericFunctionInstantiationExpr.expected Updates instantiation results.
go/ql/lib/change-notes/2026-06-25-go-1.27.md Announces Go 1.27 support.
docs/codeql/reusables/supported-versions-compilers.rst Documents Go 1.27 support.

Review details

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

  • Files reviewed: 14/15 changed files
  • Comments generated: 1
  • Review effort level: Balanced

Comment thread go/extractor/extractor.go
Comment on lines +1676 to +1683
// As a parent we use the origin method. This suffices, as the name
// and index of the type parameter in the instantiation will be
// identical to those of the uninstantiated method, and as only
// these two properties will be extracted for a type parameter.
if tp.Method(i) != meth {
signature := tp.Method(i).Type().(*types.Signature)
populateTypeParamParents(signature.TypeParams(), meth, false)
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

depends on internal PR This PR should only be merged in sync with an internal Semmle PR documentation Go

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants