Skip to content

fix(deps): upgrade electron-builder security patches - #243

Open
arhxam wants to merge 1 commit into
getopenscreen:mainfrom
arhxam:codex/upgrade-electron-builder-security
Open

fix(deps): upgrade electron-builder security patches#243
arhxam wants to merge 1 commit into
getopenscreen:mainfrom
arhxam:codex/upgrade-electron-builder-security

Conversation

@arhxam

@arhxam arhxam commented Aug 4, 2026

Copy link
Copy Markdown

Summary

  • upgrade electron-builder from 26.14.0 resolved to 26.15.3
  • pull in app-builder-lib@26.15.3 and builder-util-runtime@9.7.0
  • patch the AppImage uncontrolled-search-path issue (GHSA-7g7r-gx96-252g) and updater credential-leak issue (GHSA-p2f4-r6v6-j797)
  • refresh the stale lockfile with the repository-pinned Node 22.22.1 / npm 10.9.4 toolchain

The audit drops from 21 findings (4 critical, 15 high, 2 low) to 7 findings (1 critical, 4 high, 2 low), with no remaining builder/publisher findings.

Related issue

No linked issue; this follows currently published npm/GitHub advisories.

Type of change

  • Bug fix
  • Feature
  • Enhancement
  • Documentation
  • Refactor / maintenance
  • Performance
  • Security

Release impact

  • Patch
  • Minor
  • Major / breaking change
  • No release note needed

Desktop impact

  • Windows
  • macOS
  • Linux
  • Installer / packaging
  • Not platform-specific

Screenshots / video

Not applicable; packaging dependency update only.

Testing

  • npm exec -- electron-builder --version26.15.3
  • npm audit --json → no remaining electron-builder/app-builder-lib/builder-util findings
  • full Vitest run: 1,531 passed; the 6 existing electron/recording/webm-seek-index.test.ts assertions are Windows-only and return unsupported-platform on macOS
  • npm run build-vite
  • npm run wb:typecheck
  • npm run lint (passes with the repository's 11 existing warnings)

Summary by CodeRabbit

  • Chores
    • Updated the desktop application packaging tooling to a newer version for improved compatibility and reliability.

@arhxam
arhxam requested a review from EtienneLescot as a code owner August 4, 2026 00:25
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: d0ed040e-9319-4c30-a996-3987991252e6

📥 Commits

Reviewing files that changed from the base of the PR and between 545043d and bd1f341.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • package.json

📝 Walkthrough

Walkthrough

The pull request updates the electron-builder development dependency from ^26.8.1 to ^26.15.3.

Changes

Electron Builder Dependency Update

Layer / File(s) Summary
Update electron-builder version
package.json
The development dependency changes from ^26.8.1 to ^26.15.3.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: etiennelescot

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the electron-builder security patch upgrade and matches the primary change.
Description check ✅ Passed The description covers the required sections, change scope, security impact, release impact, platform impact, and testing results.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant