fix(check): stop trivy from scanning caches and racing pip-audit - #132
Merged
Conversation
`check:scan` and `check:vuln` run in parallel under `mise run check`. pip-audit writes temporary files into `.cache/pip-audit` while `trivy fs .` is walking the same tree, and trivy aborts with a fatal "no such file or directory" when one of them disappears mid-walk. Reproduced on the cookiecutter harness, which runs the identical task pair. Caches and virtualenvs are not source, so skip them outright rather than serialising the two checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check:scanandcheck:vulnrun in parallel undermise run check. pip-audit writes temporary files into.cache/pip-auditwhiletrivy fs .walks the same tree, and trivy aborts fatally when one disappears mid-walk. Reproduced on the cookiecutter harness, which runs the identical task pair.Caches and virtualenvs are not source, so
trivy.yamlskips them outright rather than serialising the two checks.Test plan
mise run checkthree consecutive times — exit 0 each time (it failed intermittently before).