Add tests for previously-uncovered paths (34% -> 66% coverage) - #6
Open
jefferis wants to merge 1 commit into
Open
Add tests for previously-uncovered paths (34% -> 66% coverage)#6jefferis wants to merge 1 commit into
jefferis wants to merge 1 commit into
Conversation
Cover the simple, mostly-pure paths that had no tests: - utils.R: check_suggested success/error; py_np import+cache - time.R: ts2pydatetime early-return and UTC conversion - int64.R: pyids2bit64 / rids2pyint round-trips (int64, uint64, overflow, empty, file/string/list marshalling) - env.R: np_condaenv, ownpythonrequested, checkownpython, the non-destructive blast branch - convert.R: object-column flattening, list-valued columns, all-NA, datetime->UTC POSIXct, and the use_arrow feather round-trip Python-backed tests are gated with skip_if_no_module() / skip_if_not_installed() so the suite still runs with no Python. The test-coverage workflow now also installs pyarrow so the use_arrow path runs on CI.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6 +/- ##
===========================================
+ Coverage 34.22% 47.62% +13.40%
===========================================
Files 6 6
Lines 485 485
===========================================
+ Hits 166 231 +65
+ Misses 319 254 -65 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds offline (and conditionally-gated) unit tests for paths that were previously uncovered, raising coverage from ~34% to ~66%.
What's tested
test-utils.R):check_suggestedsuccess/error paths;py_npimport + caching (numpy-gated).test-time.R):ts2pydatetimeearly-return; datetime-gated UTC round-trip.test-int64.R):pyids2bit64round-trips (int64/uint64/overflow/empty/dtype error) andrids2pyintround-trips (string/file/list/numpy passthrough) — numpy-gated.test-env.R):np_condaenv,ownpythonrequested,checkownpython,check_reticulate,simple_python_base— non-destructive.test-convert.R): object-column flattening + datetime normalisation; twouse_arrow = TRUEround-trip tests (pandas + pyarrow + R arrow gated).CI
test-coverage.yamlnow installspyarrowso theuse_arrow = TRUEconversion path is exercised in CI.All new tests skip gracefully when their Python module (numpy / pandas / pyarrow) or R suggest is unavailable.