Insert gradient reduction during pass expansion when multiple consumers use the same input - #1666
Open
elliottslaughter wants to merge 8 commits into
Open
Insert gradient reduction during pass expansion when multiple consumers use the same input#1666elliottslaughter wants to merge 8 commits into
elliottslaughter wants to merge 8 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the backward pass, a value used multiple times by different nodes results in gradients that must be summed together to produce the final result. This PR adds a new
GradientReductionnode type to implement this, along with asubgradient_id_tonDynamicValueAttrsto track the distinct sub-gradients that contribute to the final result, and then updates pass expansion to detect the duplicate values in the backward pass and insertGradientReductions for them.This change is