Skip to content

feat(cli): remove audit-list #950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davidfrigolet wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(cli): remove audit-list #950

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ...ore-commons/src/main/java/io/flamingock/internal/common/core/operation/OperationType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ public enum OperationType {
EXECUTE_ROLLBACK,
EXECUTE_DRYRUN,
VALIDATE_APPLY,
AUDIT_LIST,
AUDIT_FIX,
ISSUE_LIST,
ISSUE_GET
Expand Down
181 changes: 0 additions & 181 deletions ...src/main/java/io/flamingock/internal/common/core/response/data/AuditListResponseData.java
View file
Open in desktop

This file was deleted.

48 changes: 0 additions & 48 deletions .../src/test/java/io/flamingock/internal/common/core/response/ResponseSerializationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@

import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.databind.jsontype.NamedType;
import io.flamingock.internal.common.core.response.data.AuditListResponseData;
import io.flamingock.internal.common.core.response.data.ChangeResult;
import io.flamingock.internal.common.core.response.data.ChangeStatus;
import io.flamingock.internal.common.core.response.data.ExecuteResponseData;
Expand All @@ -30,8 +29,6 @@
import org.junit.jupiter.api.Test;

import java.time.Instant;
import java.time.LocalDateTime;
import java.util.Arrays;

import static org.junit.jupiter.api.Assertions.*;

Expand All @@ -47,7 +44,6 @@ void setUp() {
// JsonObjectMapper.DEFAULT_INSTANCE already includes JavaTimeModule
objectMapper = JsonObjectMapper.DEFAULT_INSTANCE.copy();
objectMapper.registerSubtypes(
new NamedType(AuditListResponseData.class, "audit_list"),
new NamedType(ExecuteResponseData.class, "execute")
);
}
Expand Down Expand Up @@ -102,50 +98,6 @@ void shouldSerializeAndDeserializeExecuteResponseData() throws Exception {
assertEquals("change-001", deserialized.getStages().get(0).getChanges().get(0).getChangeId());
}

@Test
@DisplayName("Should serialize and deserialize AuditListResponseData")
void shouldSerializeAndDeserializeAuditListResponseData() throws Exception {
// Given
AuditListResponseData original = new AuditListResponseData(Arrays.asList(
new AuditListResponseData.AuditEntryDto(
"change-001",
"developer",
"APPLIED",
"stage-1",
LocalDateTime.of(2026, 2, 9, 10, 0, 0),
100
),
new AuditListResponseData.AuditEntryDto(
"change-002",
"developer",
"APPLIED",
"stage-1",
LocalDateTime.of(2026, 2, 9, 10, 0, 1),
150
)
));

// When
String json = objectMapper.writeValueAsString(original);
AuditListResponseData deserialized = objectMapper.readValue(json, AuditListResponseData.class);

// Then
assertNotNull(deserialized);
assertNotNull(deserialized.getEntries());
assertEquals(2, deserialized.getEntries().size());

AuditListResponseData.AuditEntryDto first = deserialized.getEntries().get(0);
assertEquals("change-001", first.getChangeId());
assertEquals("developer", first.getAuthor());
assertEquals("APPLIED", first.getState());
assertEquals("stage-1", first.getStageId());
assertEquals(100, first.getExecutionMillis());

AuditListResponseData.AuditEntryDto second = deserialized.getEntries().get(1);
assertEquals("change-002", second.getChangeId());
assertEquals(150, second.getExecutionMillis());
}

@Test
@DisplayName("Should serialize ResponseEnvelope with polymorphic data")
void shouldSerializeResponseEnvelopeWithPolymorphicData() throws Exception {
Expand Down
17 changes: 0 additions & 17 deletions ...lamingock-core/src/main/java/io/flamingock/internal/core/operation/OperationResolver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,11 @@
import io.flamingock.internal.core.builder.args.FlamingockArguments;
import io.flamingock.internal.core.configuration.core.CoreConfigurable;
import io.flamingock.internal.core.event.EventPublisher;
import io.flamingock.internal.common.core.audit.AuditPersistence;
import io.flamingock.internal.core.external.store.AuditStore;
import io.flamingock.internal.core.external.targets.TargetSystemManager;
import io.flamingock.internal.core.operation.audit.AuditFixArgs;
import io.flamingock.internal.core.operation.audit.AuditFixOperation;
import io.flamingock.internal.core.operation.audit.AuditFixResult;
import io.flamingock.internal.core.operation.audit.AuditListArgs;
import io.flamingock.internal.core.operation.audit.AuditListOperation;
import io.flamingock.internal.core.operation.audit.AuditListResult;
import io.flamingock.internal.core.operation.execute.*;
import io.flamingock.internal.core.operation.issue.IssueGetArgs;
import io.flamingock.internal.core.operation.issue.IssueGetOperation;
Expand All @@ -49,9 +45,6 @@

public class OperationResolver {

private static final String ARG_HISTORY = "flamingock.audit.history";
private static final String ARG_SINCE = "flamingock.audit.since";
private static final String ARG_EXTENDED = "flamingock.audit.extended";
private static final String ARG_CHANGE_ID = "flamingock.change-id";
private static final String ARG_RESOLUTION = "flamingock.resolution";
private static final String ARG_GUIDANCE = "flamingock.guidance";
Expand Down Expand Up @@ -104,8 +97,6 @@ public OperationResolver(RunnerId runnerId,
return getExecuteApplyOperation();
case VALIDATE_APPLY:
return getValidateApplyOperation();
case AUDIT_LIST:
return getAuditListOperation();
case AUDIT_FIX:
return getAuditFixOperation();
case ISSUE_LIST:
Expand All @@ -117,14 +108,6 @@ public OperationResolver(RunnerId runnerId,
}
}

private RunnableOperation<AuditListArgs, AuditListResult> getAuditListOperation() {
boolean history = flamingockArgs.getBooleanOr(ARG_HISTORY, false);
java.time.LocalDateTime since = flamingockArgs.getDateTimeOr(ARG_SINCE, null);
boolean extended = flamingockArgs.getBooleanOr(ARG_EXTENDED, false);
AuditListOperation auditListOperation = new AuditListOperation(auditStore.getAuditReader());
return new RunnableOperation<>(auditListOperation, new AuditListArgs(history, since, extended));
}

private RunnableOperation<AuditFixArgs, AuditFixResult> getAuditFixOperation() {
String changeId = flamingockArgs.getStringOrThrow(ARG_CHANGE_ID,
"Change ID is required for AUDIT_FIX operation");
Expand Down
49 changes: 0 additions & 49 deletions ...mingock-core/src/main/java/io/flamingock/internal/core/operation/audit/AuditListArgs.java
View file
Open in desktop

This file was deleted.

Loading
Loading