feat!: Kill MultiTouchTapDetector and MultiTouchDragDetector - #4000
Merged
Conversation
luanpotter
marked this pull request as ready for review
August 15, 2026 21:13
spydon
approved these changes
Aug 16, 2026
spydon
approved these changes
Aug 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Kill
MultiTouchTapDetectorandMultiTouchDragDetectorin favour of the existingTapCallbacksandDragCallbacks(already supported on both component and flame game level). ThepointerIdthat used to be a callback parameter is now carried on the event (event.pointerId), so multi-touch tracking is unchanged.The
MultiTouchDragDetector/PanDetectorconflict assert inGameWidgetcan die too, along with the note ingesture_input.mdexplaining that advanced detectors always win the gesture arena (MultiDragScaleDispatcheris our new shape and natively handles this under the hood).Note that while
TapCallbackshas noMultiTouchTapDetector.onTap, Flutter's "tap completed" callback, you can useonTapUpinstead.Also cleans up tangent things, such as the game's MultiTapListener branch in initializeGestures and the matching clause in containsEventHandlerAt, which are now unreachable; the docs for legacy are updated, with generic sessions (which were already referencing other dead code) just shifting to other (still existent) legacy examples (we could just delete it, but I'd rather keep deleting piece-meal with each PR for absolute clarity), and finally general reframing tweaks on that doc around the legacy vs new system.
Finally this is adding the migration entry for the prior removal that I forgot (:facepalm:), alongside this one's.
Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?