Convert PC Python objects into strings - #46
Open
connorjward wants to merge 4 commits into
Open
Conversation
Member
|
I am very happy with this functionality! One small request. Can we have a test that non-PC objects also get converted? class MyPythonSNES:
pass
def test_python_type_option():
with petsctools.inserted_options(
parameters={
"snes_type": "python",
"snes_python_type": MyPythonSNES,
}
):
assert PETSc.Options()["snes_python_type"] == f"{__name__}.MyPythonSNES", "Python type name was not substituted into the options dictionary" |
Member
As discussed, I added the test in 78ded27 |
connorjward
marked this pull request as ready for review
August 25, 2026 13:14
connorjward
commented
Aug 25, 2026
| appmngr = AppContextManager() | ||
| for key, value in parameters.items(): | ||
| if not isinstance(value, _native_petsc_option_types): | ||
| # Convert Python PC objects into their string representation |
Collaborator
Author
There was a problem hiding this comment.
Suggested change
| # Convert Python PC objects into their string representation | |
| # Convert Python objects into their string representation for things | |
| # like 'pc_python_type' and 'snes_python_type' |
JHopeCollins
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes it much more pleasant to construct preconditioners.
It really is that easy.
(Tests and Firedrake PR to follow)