Skip to content

Disable the other new Messaging test on Desktop - #1908

Merged
a-maurice merged 1 commit into
mainfrom
am-messaging_test
Aug 12, 2026
Merged

Disable the other new Messaging test on Desktop#1908
a-maurice merged 1 commit into
mainfrom
am-messaging_test

Conversation

@a-maurice

Copy link
Copy Markdown
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

The other new Messaging test will also have problems on Desktop because of the stubbed out implementation, so disable it.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@a-maurice a-maurice added the skip-release-notes Skip release notes check label Aug 11, 2026
@a-maurice
a-maurice requested a review from AustinBenoit August 11, 2026 23:57

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the integration test TestRegistrationOnInitEnabled in messaging/integration_test/src/integration_test.cc to skip execution on desktop and Android emulator environments. There are no review comments, so I have no feedback to provide.

@a-maurice
a-maurice merged commit f88533e into main Aug 12, 2026
39 of 55 checks passed
@a-maurice
a-maurice deleted the am-messaging_test branch August 12, 2026 16:53
@github-actions github-actions Bot added the tests: in-progress This PR's integration tests are in progress. label Aug 12, 2026
@github-actions

github-actions Bot commented Aug 12, 2026

Copy link
Copy Markdown

❌  Integration test FAILED

Requested by @a-maurice on commit f88533e
Last updated: Wed Aug 12 15:01 PDT 2026
View integration test log & download artifacts

Failures Configs
missing_log [TEST] [ERROR] [Android] [All 3 os] [1/2 android_device: android_target]
firestore [BUILD] [ERROR] [Android] [1/3 os: windows]
remote_config [BUILD] [ERROR] [Android] [1/3 os: macos]

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions Bot added the tests: failed This PR's integration tests failed. label Aug 12, 2026
@firebase-workflow-trigger firebase-workflow-trigger Bot removed the tests: in-progress This PR's integration tests are in progress. label Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants