[eas-cli] Add prebuild fallback regression tests - #4285
Open
brentvatne wants to merge 2 commits into
Open
Conversation
|
Subscribed to pull request
Generated by CodeMention Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead. |
|
✅ Thank you for adding the changelog entry! |
This was referenced Aug 26, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## brent/local-build-expo-bunyan #4285 +/- ##
=================================================================
+ Coverage 64.14% 64.19% +0.05%
=================================================================
Files 1046 1046
Lines 48101 48101
Branches 10151 10151
=================================================================
+ Hits 30851 30872 +21
+ Misses 17134 17113 -21
Partials 116 116 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
EAS CLI has a bundled
@expo/prebuild-configfallback for iOS entitlement introspection when Expo is unavailable or the project-local Expo CLI fails. A dependency bump can silently make that fallback require Expo and substantially expand published installs.How
Add regression coverage that verifies:
Test Plan
yarn workspace eas-cli test src/project/ios/__tests__/entitlements-test.ts --runInBand --watchman=false(3 tests)yarn workspace eas-cli typecheckStack
minizlib3.1.0uuidv11lodash.get@expo/bunyanThis final stack item is regression coverage only; it does not change a dependency.