[eas-cli] Use development mode for Fingerprint - #4246
Open
ramonclaudio wants to merge 3 commits into
Open
Conversation
|
✅ Thank you for adding the changelog entry! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## @ramonclaudio/dvt-119-eas-cli-env-mode #4246 +/- ##
==========================================================================
+ Coverage 63.88% 63.98% +0.10%
==========================================================================
Files 1033 1033
Lines 47535 47543 +8
Branches 9999 9999
==========================================================================
+ Hits 30365 30416 +51
+ Misses 17069 17026 -43
Partials 101 101 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ramonclaudio
marked this pull request as ready for review
August 21, 2026 17:37
|
Subscribed to pull request
Generated by CodeMention Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #4229.
Why
Fingerprint can inherit dotenv vars and
NODE_ENVfrom a parent process, which can make it load different env files for the same project.How
I updated EAS CLI to remove inherited dotenv vars and use
developmentmode while it creates project fingerprints. We also wait for every Fingerprint call to finish before restoring the original EAS CLI env.Test Plan
Tests and package checks pass.