[eas-cli] Remove inherited dotenv values from local builds - #4244
Open
ramonclaudio wants to merge 3 commits into
Open
[eas-cli] Remove inherited dotenv values from local builds#4244ramonclaudio wants to merge 3 commits into
ramonclaudio wants to merge 3 commits into
Conversation
|
✅ Thank you for adding the changelog entry! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## @ramonclaudio/dvt-119-eas-cli-env-mode #4244 +/- ##
==========================================================================
+ Coverage 63.88% 63.89% +0.01%
==========================================================================
Files 1033 1033
Lines 47535 47537 +2
Branches 9999 9999
==========================================================================
+ Hits 30365 30368 +3
+ Misses 17069 17068 -1
Partials 101 101 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ramonclaudio
marked this pull request as ready for review
August 21, 2026 17:37
|
Subscribed to pull request
Generated by CodeMention Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead. |
kitten
reviewed
Aug 21, 2026
| }; | ||
| process.on('SIGINT', interruptHandler); | ||
| try { | ||
| const processEnv = getEnvWithoutInheritedDotenvValues(process.env); |
Member
There was a problem hiding this comment.
EXPO_UNSAFE_DOTENV_KEYS and this utility is something I'm not familiar with 🤔 maybe @sjchmiela or @szdziedzic can evaluate this better. I believe, this may be similar to a utility for original-env we have in @expo/env, so not sure if we need to reconsolidate?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #4229.
Why
eas build --localcan pass dotenv values inherited from a parent process to the local-build plugin, so the local build can use values from a different mode.How
I updated
eas build --localto remove inherited dotenv values before starting the local-build plugin and keep the env vars passed by EAS.Test Plan
Tests and package checks pass.