Skip to content

[build-tools] Separate iOS ccache by destination - #4238

Merged
sjchmiela merged 1 commit into
mainfrom
stanley/separate-ios-simulator-ccache
Aug 24, 2026
Merged

[build-tools] Separate iOS ccache by destination#4238
sjchmiela merged 1 commit into
mainfrom
stanley/separate-ios-simulator-ccache

Conversation

@sjchmiela

@sjchmiela sjchmiela commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Why

Looks like ccache cache built for iOS simulator is not helpful for iOS device builds and vice versa.

Context: https://exponent-internal.slack.com/archives/C08PBDW7ZC3/p1787242902697509?thread_ts=1787171142.251299&cid=C08PBDW7ZC3

How

Separated ios-device-ccache- and ios-simulator-ccache- ccaches.

Test Plan

  • Before: the simulator build restored the device build’s cache, got 0 hits, and could not save its own cache because the key already existed.
  • After: the device and simulator builds used separate keys. The simulator build got 48 direct hits.

@codecov

codecov Bot commented Aug 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 30.43478% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.72%. Comparing base (ce93a92) to head (aeed5f8).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...ild-tools/src/steps/functions/restoreBuildCache.ts 0.00% 7 Missing ⚠️
.../build-tools/src/steps/functions/saveBuildCache.ts 12.50% 7 Missing ⚠️
packages/build-tools/src/utils/cacheKey.ts 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4238      +/-   ##
==========================================
- Coverage   63.73%   63.72%   -0.01%     
==========================================
  Files        1030     1030              
  Lines       47448    47464      +16     
  Branches     9977     9989      +12     
==========================================
+ Hits        30237    30241       +4     
- Misses      17110    17122      +12     
  Partials      101      101              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sjchmiela sjchmiela added the no changelog PR that doesn't require a changelog entry label Aug 20, 2026
@github-actions

Copy link
Copy Markdown

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

@sjchmiela
sjchmiela marked this pull request as ready for review August 20, 2026 17:18
@sjchmiela
sjchmiela requested a review from AbbanMustafa August 20, 2026 17:18

@AbbanMustafa AbbanMustafa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@sjchmiela
sjchmiela merged commit 97d64f4 into main Aug 24, 2026
17 of 18 checks passed
@sjchmiela
sjchmiela deleted the stanley/separate-ios-simulator-ccache branch August 24, 2026 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog PR that doesn't require a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants