Fixed MISRA rule 12.7 for GX_FIXED_VAL_... macros - #171
Open
parsley wants to merge 1 commit into
Open
Conversation
…ng shift operations on signed operands with mul/div operations. On these lines also rule 19.10 got addressed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed MISRA rule 12.7 violation on GX_FIXED_VAL_... macros by replacing shift operations on signed operands with mul/div operations.
On these lines also rule 19.10 got addressed.
Luckily this fix was relatively easy because GX_FIXED_VAL_SHIFT and GX_FIXED_VAL_ONE are both available and match.
I did not check all occurrences of GX_FIXED_VAL_SHIFT.
If this PR is not covering everything please feel free to change it, extend it or convert it in a feature request. 😉 I hope this helps.