Feat validate form include list - #8314
Conversation
…只有第一个文本框出现了错误验证" This reverts commit 3e14654.
|
Thanks for your PR, @zijiaxing. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Reviewer's guide (collapsed on small PRs)Reviewer's Guide.gitignore configuration was modified, likely to adjust which files are tracked or ignored by git; no application/runtime logic appears to be affected. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The PR title and description suggest form validation changes, but the diff only touches .gitignore; please align the PR metadata with the actual change or include the intended code changes.
- Double-check that the updated .gitignore patterns do not unintentionally ignore source or configuration files needed for local development or CI builds, and scope any new ignore rules as narrowly as possible.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The PR title and description suggest form validation changes, but the diff only touches .gitignore; please align the PR metadata with the actual change or include the intended code changes.
- Double-check that the updated .gitignore patterns do not unintentionally ignore source or configuration files needed for local development or CI builds, and scope any new ignore rules as narrowly as possible.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
@zijiaxing please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement ( “Agreement” ) is agreed to by the party signing below ( “You” ), 1. Definitions. “Code” means the computer software code, whether in human-readable or machine-executable form, “Project” means any of the projects owned or managed by .NET Foundation and offered under a license “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any “Submission” means the Code and any other copyrightable material Submitted by You, including any 2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any 3. Originality of Work. You represent that each of Your Submissions is entirely Your 4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else 5. Licenses. a. Copyright License. You grant .NET Foundation, and those who receive the Submission directly b. Patent License. You grant .NET Foundation, and those who receive the Submission directly or c. Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement. 6. Representations and Warranties. You represent that You are legally entitled to grant the above 7. Notice to .NET Foundation. You agree to notify .NET Foundation in writing of any facts or 8. Information about Submissions. You agree that contributions to Projects and information about 9. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and 10. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and .NET Foundation dedicates this Contribution License Agreement to the public domain according to the Creative Commons CC0 1. |
Signed-off-by: zijiaxing <362293875@qq.com>
|
@zijiaxing 感谢提交 PR 但是这个 PR 没有文件更改,是不是搞错了 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8314 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 771 771
Lines 34535 34535
=========================================
Hits 34535 34535
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
因为本地添加了一个新的测试项目,第一次提交的时候把这个测试项目提交上去了,然后就又修改了一下,重新提交了。所以导致提交了好几次。 |
|
@zijiaxing 继续往这个分支里提交代码即可,不需要关闭这个 PR 的,再弄弄。目前看不到 PR 的内容 |
|
@zijiaxing 代码改动太大了,非常抱歉无法合并这个分支,这样更改非常容易导致新 bug 不过可以新开一个讨论,先讨论一下如何做 List 的验证 |
好的 |
Link issues
fixes #5957
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Update repository ignore rules in .gitignore.