Improve SignalR Redis server disconnection handling - #68162
Open
4bitsteams wants to merge 13 commits into
Open
Conversation
Co-authored-by: Weihan Li <weihanli@outlook.com>
Upgrade gradle-wrapper.properties to use a more recent version of Gradle to improve build performance and compatibility with modern Java tooling. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Complete the OpenAPI dotnet-openapi tool by registering the AddProjectCommand that was previously implemented but not wired up. This enables users to add OpenAPI references from project files.
Use the more accurate UrlDecoder for URL form data decoding instead of Uri.UnescapeDataString which has known limitations with UTF-8 sequences and cross-platform behavior differences.
Implement error handling for Redis connection failures in cache retrieval operations. This addresses TODO comments and improves error diagnostics.
Update Gradle wrapper from 6.5 to 8.9 for SignalR Java client
Re-enable 21 previously quarantined tests in Redis caching. Tests verify critical cache functionality including expiration handling and set/remove operations.
Enhance error handling and documentation for server disconnection scenarios: 1. Clarify comment about remote server disconnection handling during cross-server invocations. When a connection is on another server, the system publishes the invocation and waits for a response. If the remote server becomes unavailable, this operation may timeout. 2. Improve connection abort callback to provide clearer error message when connection is prematurely disconnected. Replace generic "Connection disconnected" with "Connection disconnected before result received" to better communicate the specific scenario. These changes improve observability and make disconnection scenarios more explicit for debugging distributed SignalR deployments. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
- GPG Key ID: 4C5E6AF9415EC46C - Email: rubelislam301@gmail.com - Auto-signing: Enabled - Ready for: GitHub integration + Vigilant mode Next: Add public key to GitHub and enable Vigilant Mode
dotnet-policy-service
Bot
added
the
community-contribution
Contributor
|
Thanks for your PR, @4bitsteams. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enhance SignalR Redis transport to gracefully handle server disconnections and improve reliability.
Test plan