Updated old twigs, added html tags and style. - #66
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #66 +/- ##
==========================================
Coverage 17.67% 17.67%
Complexity 250 250
==========================================
Files 55 55
Lines 1058 1058
==========================================
Hits 187 187
Misses 871 871 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
|
||
| $sourceIndex = indexUploadSources($uploadsDir, $ogDir); | ||
|
|
||
| if (! is_dir($ogDir) && ! mkdir($ogDir, 0775, true) && ! is_dir($ogDir)) { |
There was a problem hiding this comment.
what is this shell file ?
It is supposed to be part of the codebase or is an one-time action to migrate images ?
There was a problem hiding this comment.
before I was using article->id in path, but now it is not usefull to be part of project.
| } | ||
|
|
||
| if ($baseUrl !== '' && str_starts_with($image, $baseUrl . '/')) { | ||
| if (str_starts_with($image, '/uploads/opengraph/article/')) { |
There was a problem hiding this comment.
the path should be: /opengraph/article/ and not /uploads/opengraph/article/
we have some misunderstandinngs here ..
There was a problem hiding this comment.
I will fix this
3 participants
No description provided.