#2219: Add UnpackCommandlet for extracting already supported archieve Formats - #2334
#2219: Add UnpackCommandlet for extracting already supported archieve Formats #2334majesteSil wants to merge 15 commits into
Conversation
…operties and Help_de.properties
…mmandlet' into feature/issue-2219-add-unpack-commandlet
Coverage Report for CI Build 32852977586Coverage increased (+0.1%) to 73.665%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions8 previously-covered lines in 2 files lost coverage.
Coverage Stats💛 - Coveralls |
There was a problem hiding this comment.
Great work on adding an unpack commandlet to IDEasy! I've tested the unpacking and it works, however the target parameter is not working. So I still have a few suggestions, mainly concerning the target parameter not working and wrong descriptions.
Also your commits have an inconsistent link to the issue (some falsely point to #2298). This should be fixed aswell.
…mmandlet' into feature/issue-2219-add-unpack-commandlet
…itional target argument
samuelkos17
left a comment
There was a problem hiding this comment.
Thanks for adding the E2E test for CLI parsing, it looks good to me! I still have a few minor style suggestions, when they're addressed this can be moved to In Review 😄
hohwille
left a comment
There was a problem hiding this comment.
@majesteSil thank you for your PR. Great that you completed your own commandlet successfully and covered it with a solid test. Also DoD was completed with CHANGELOG, etc.
Great job 👍
I left two small comments for improvement that should be addressed easy and quickly. Then we can merge.
|
|
||
| @Override | ||
| public boolean isIdeRootRequired() { | ||
|
|
||
| return false; | ||
| } |
There was a problem hiding this comment.
Isn't the unpack routine in FileAccess first extracting to a temporary directory that is technically $IDE_ROOT/tmp?
If I am not mistaken then we should remove this:
| @Override | |
| public boolean isIdeRootRequired() { | |
| return false; | |
| } |
| super(context); | ||
| addKeyword(getName()); | ||
|
|
||
| this.archive = add(new PathProperty("", true, "archive", true)); |
There was a problem hiding this comment.
Should be a FileProperty instead of a PathProperty. Specifying a folder as archive does not seem to make sense.
This PR fixes #2219
Adds a new "unpack" commandlet that extracts archive files into a target directory. The commandlet supports ZIP, TAR, TAR.GZ, TAR.BZ2, 7Z, JAR (cross-platform) and notes platform-specific formats like MSI/DMG/PKG. The commandlet is registered in the commandlet manager and covered by unit tests.
Implemented changes:
Testing instructions
Please add conscise, understandable instructions on how a reviewer can test/verify the functionality of your contribution here:
Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.batand notfeature/921 fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internalpom.xmlfiles or otherwise if runtime dependencies changed, you have updated our LICENSE.asciidoc