Skip to content

#2186: create obsidian url updater - #2203

Merged
hohwille merged 20 commits into
devonfw:mainfrom
JoelAdbu:feature/2186-create-obsidian-urlupdater
Aug 25, 2026
Merged

#2186: create obsidian url updater#2203
hohwille merged 20 commits into
devonfw:mainfrom
JoelAdbu:feature/2186-create-obsidian-urlupdater

Conversation

@JoelAdbu

@JoelAdbu JoelAdbu commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

This PR fixes #2186

Implemented changes:

  1. Add Obsidian URL updater.
  2. Generate platform-specific download URLs from Obsidian GitHub releases.
  3. Add integration test and mocked release data.

Testing instructions

Please add conscise, understandable instructions on how a reviewer can test/verify the functionality of your contribution here:

  1. Run mvn clean test.
  2. Verify that ObsidianUrlUpdaterTest passes.

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
    with internal
  • You have formulated clear instructions on how to test your contribution under "Testing instructions"

@github-project-automation github-project-automation Bot moved this to 🆕 New in IDEasy board Jul 22, 2026
@JoelAdbu JoelAdbu self-assigned this Jul 22, 2026
@JoelAdbu JoelAdbu added enhancement New feature or request urls ide-urls repo and related processes and features obsidian labels Jul 22, 2026
@JoelAdbu JoelAdbu moved this from 🆕 New to Team Review in IDEasy board Jul 22, 2026
@vivu001 vivu001 self-assigned this Jul 23, 2026
@vivu001

vivu001 commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

I’ve run the tests and everything passed successfully. The implementation looks good and follows a proper approach.
LGTM 👍

One minor remark: please update the changelog before merging.

@coveralls

coveralls commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 32852501979

Coverage increased (+0.04%) to 73.602%

Details

  • Coverage increased (+0.04%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 16 coverage regressions across 2 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

16 previously-covered lines in 2 files lost coverage.

File Lines Losing Coverage Coverage
com/devonfw/tools/ide/url/updater/UpdateManager.java 15 38.82%
com/devonfw/tools/ide/version/VersionSegment.java 1 90.03%

Coverage Stats

Coverage Status
Relevant Lines: 18184
Covered Lines: 13991
Line Coverage: 76.94%
Relevant Branches: 8060
Covered Branches: 5325
Branch Coverage: 66.07%
Branches in Coverage %: Yes
Coverage Strength: 3.28 hits per line

💛 - Coveralls

@JoelAdbu
JoelAdbu requested a review from vivu001 July 29, 2026 06:00
@JoelAdbu
JoelAdbu force-pushed the feature/2186-create-obsidian-urlupdater branch from 052a88f to 5b5f563 Compare July 29, 2026 06:06
@vivu001
vivu001 removed their request for review July 30, 2026 09:34
@JoelAdbu JoelAdbu moved this from Team Review to 👀 In review in IDEasy board Jul 30, 2026
@JoelAdbu
JoelAdbu force-pushed the feature/2186-create-obsidian-urlupdater branch 4 times, most recently from 98bdab9 to 7efe13d Compare August 6, 2026 12:07
- Add Obsidian URL updater, test and release mock data
added Obsidian url updater to updateManager

# Conflicts:
#	url-updater/src/main/java/com/devonfw/tools/ide/url/updater/UpdateManager.java

# Conflicts:
#	url-updater/src/main/java/com/devonfw/tools/ide/url/updater/UpdateManager.java
- added arm64 updater for obsidian
- improved obsidian-releases mock
- add changelog
@JoelAdbu
JoelAdbu force-pushed the feature/2186-create-obsidian-urlupdater branch from 7efe13d to 5926c82 Compare August 10, 2026 08:59

@hohwille hohwille left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoelAdbu thanks for your PR. I checked this on github and all seems to be fully correct. 👍
I only have a tiny comment before we merge.

Comment thread url-updater/src/main/java/com/devonfw/tools/ide/url/updater/UpdateManager.java Outdated
@hohwille hohwille added this to the release:2026.08.002 milestone Aug 21, 2026
Comment thread CHANGELOG.adoc Outdated
@hohwille
hohwille merged commit ea838b0 into devonfw:main Aug 25, 2026
4 checks passed
@github-project-automation github-project-automation Bot moved this from 👀 In review to ✅ Done in IDEasy board Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request obsidian urls ide-urls repo and related processes and features

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Create ObsidianUrlUpdater

5 participants