docs(workspace-config): document executionOrder shape validation and … - #103
Open
finalerock44 wants to merge 1 commit into
Open
docs(workspace-config): document executionOrder shape validation and …#103finalerock44 wants to merge 1 commit into
finalerock44 wants to merge 1 commit into
Conversation
…fix continueOnFailure default Two corrections to the executionOrder section, prompted by dcd-cli#110: - continueOnFailure was documented as defaulting to false. The CLI has always defaulted it to true (three read sites agree, and it is now the schema default). Corrected, with a note on when to set it to false. - Added a warning block for the shape mistake the issue reported: a bare list of flow names under executionOrder. It is not valid Maestro, older CLI versions silently ignored it and ran every flow in parallel while still reporting success, and the CLI now rejects it outright. Shows the wrong and right forms side by side so it is findable by anyone hitting the error. Also noted that unrecognised top-level keys are now warned about, which is what catches flowOrder, a top-level continueOnFailure, and tags: in place of includeTags/excludeTags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…fix continueOnFailure default
Two corrections to the executionOrder section, prompted by dcd-cli#110:
Also noted that unrecognised top-level keys are now warned about, which is what catches flowOrder, a top-level continueOnFailure, and tags: in place of includeTags/excludeTags.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is enabled.