feat: Tradingview Lightweight Charts by jnumainville · Pull Request #1402 · deephaven/deephaven-plugins

jnumainville · 2026-08-19T20:29:21Z

A record of most changes I made on top of Don's work is in plans/DH-1376-tradingview-lightweight-review.md
I also added a continuous argument (default True) to charts. Generally, this means data gaps aren't erased by default. This will make it so histograms are truly bar-to-bar, for a specific example. Setting to False switches back to the default ordinal rendering mode for those desiring it.

Since it is impossible to pin down everything without taking significant developer effort, I think our best bet is noting this as a beta plugin. If further work is highly desirable once initially surfaced we can dedicate more resources.

… restore correctly.

Co-authored-by: Copilot <copilot@github.com>

# Conflicts: # package-lock.json # package.json # tests/app.d/tests.app

# Conflicts: # package-lock.json # tests/app.d/tests.app

*_series constructors and chart-level kwargs on per-type constructors were removed; compose via tvl.chart(...) instead. Fixes server startup crash in e2e docker container. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

…s them Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

# Conflicts: # tests/app.d/tests.app

Fix pre-existing lint errors that fail `npm run test:ci` (test:ci:lint): - Move @deephaven/dashboard-core-plugins from devDependencies to dependencies (imported by non-test source; import/no-extraneous-deps) - strict-boolean-expressions: explicit null/empty checks - no-shadow: rename shadowing pendingDs locals to pendingResample - no-param-reassign: house-style inline disables for intentional mutation - no-nested-ternary: hoist chart-type formatter selection to if/else - drop unused error/isLoading state value bindings - normalize isDownsampleSwap to a definite boolean - consistent-type-imports, no-empty-function, react/destructuring-assignment, jsx-props-no-spreading, max-classes-per-file, and prettier formatting Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Remove 6 of the 7 eslint-disable comments added when first fixing lint, addressing the root causes instead: - no-explicit-any: pendingDownsample is a public field; drop the `as any` - no-param-reassign (x2): mutate via array-index locals, not forEach params - jsx-props-no-spreading (x2): destructure and pass props explicitly in tests - max-classes-per-file: make MockResizeObserver a mock factory (one class left) The one remaining disable (react-hooks/exhaustive-deps on the DOM-derived useDHChartTheme memo) is kept intentionally — it matches the established convention in the ui plugin for memos that depend on non-scope DOM state. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

The tvl plugin lagged the rest of the repo (e.g. dashboard-core-plugins ^0.85.42, components ^1.2.0, plugin ^1.2.0). Bump the shared @deephaven/* deps to the versions the sibling plugins (pivot / pivot-builder / plotly- express) pin, which are already hoisted at the workspace root: - components ^1.22.1, dashboard ^1.24.0, dashboard-core-plugins ^1.24.0, jsapi-bootstrap ^1.23.0, log ^1.8.0, plugin ^1.24.0, redux ^1.23.0, utils ^1.10.0, jsapi-types ^1.0.0-dev0.39.6 This dedupes the previously-nested dashboard-core-plugins@0.85.x tree onto the root 1.24.0 install (removing ~167 stale packages). Verified: repo-wide tsc, full build, and test:ci (unit + lint) all pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

@ts-ignore

Cut the tradingview-lightweight plugin's eslint-disable comments from 72 to 4 by fixing the underlying issues instead of suppressing them: Production source: - no-explicit-any (33): use real @deephaven/jsapi-types / lightweight-charts types (Widget.sendMessage, PartitionedTable, plot.Downsample, DateWrapper, Event<T>, IRange/LogicalRange), access now-public model fields directly, and add a declaration.d.ts for the `*.css?inline` import (drops @ts-ignore) - no-param-reassign (2): resolve colors into locals, not the params - no-continue (3): wrap loop bodies in positive conditions - no-non-null-assertion (1): get-or-create map entry - class-methods-use-this (1): make unwrapValue static - import/prefer-default-export (1): default-export the plugin Tests: - no-new (16): assign construction to a var + assert defined (house pattern) - no-underscore-dangle (9) + no-var-requires (1): expose mock internals under non-underscore names, import the same mock instance via `import * as` - no-explicit-any (2): `as never` / typed casts The 4 remaining are deliberate and match repo convention: react-hooks/ exhaustive-deps on two DOM-derived effects/memos (as the ui plugin does), and no-underscore-dangle on the intentional `__tvlTestHook` global debug hook. Verified: repo-wide tsc, build, and test:ci (unit + lint, 332 suites) all pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

github-actions · 2026-08-20T20:45:21Z

ui docs preview (Available for 14 days)

github-actions · 2026-08-20T20:45:26Z

plotly-express docs preview (Available for 14 days)

github-actions · 2026-08-20T21:29:14Z

ui docs preview (Available for 14 days)

github-actions · 2026-08-20T21:29:15Z

plotly-express docs preview (Available for 14 days)

github-actions · 2026-08-20T21:48:29Z

ui docs preview (Available for 14 days)

github-actions · 2026-08-20T21:48:31Z

plotly-express docs preview (Available for 14 days)

github-actions · 2026-08-20T21:48:32Z

tradingview-lightweight docs preview (Available for 14 days)

github-actions · 2026-08-24T20:39:27Z

tradingview-lightweight docs preview (Available for 14 days)

github-actions · 2026-08-24T20:39:28Z

ui docs preview (Available for 14 days)

github-actions · 2026-08-24T20:39:31Z

plotly-express docs preview (Available for 14 days)

github-actions · 2026-08-25T14:22:14Z

tradingview-lightweight docs preview (Available for 14 days)

github-actions · 2026-08-25T14:22:14Z

ui docs preview (Available for 14 days)

github-actions · 2026-08-25T14:22:18Z

plotly-express docs preview (Available for 14 days)

github-actions · 2026-08-25T16:42:38Z

plotly-express docs preview (Available for 14 days)

github-actions · 2026-08-25T16:42:39Z

tradingview-lightweight docs preview (Available for 14 days)

github-actions · 2026-08-25T16:42:39Z

ui docs preview (Available for 14 days)

Copilot

Pull request overview

Introduces the beta TradingView Lightweight Charts plugin, including Python APIs, JavaScript rendering, documentation, tests, and snapshot infrastructure.

Changes:

Adds chart types, continuous time rendering, themes, tooltips, events, and downsampling.
Adds Python, Jest, Playwright, and documentation coverage.
Extends Docker-based documentation snapshot generation.

Reviewed changes

Copilot reviewed 54 out of 623 changed files in this pull request and generated 10 comments.

Show a summary per file

File(s)	Description
`plugins/tradingview-lightweight/**`	New plugin implementation, packaging, tests, fixtures, docs, and snapshots.
`tools/image-snapshotter/**`	New chart-image snapshot generation and validation tooling.
`tests/**`	Adds TVL fixtures and stabilizes visual tests.
`plugins/ui/.../useDebouncedOnChange*`	Prevents callback replacement from dropping pending changes.
`sphinx_ext/deephaven_autodoc.py`	Handles raises sections and MDX brace escaping.
`docker-compose.docs.yml`, `docker/python/**`	Integrates TVL into documentation containers.
`tools/run_docker.sh`, `package.json`	Updates snapshot orchestration and diagnostics.
`.github/actions/get-changes/action.yml`	Adds TVL change detection.
`.gitignore`	Adds Python artifact exclusions.

Suppressed comments (3)

plugins/tradingview-lightweight/README.md:38

chart() deliberately hard-broke these flat kwargs. The runnable example must use the grouped crosshair and time_scale objects or it raises TypeError.
plugins/tradingview-lightweight/docs/README.md:60
This terminology entry repeats the nonexistent pane_index parameter; the constructors select a pane with pane=.
plugins/tradingview-lightweight/README.md:134
plugin_builder.py has no --plugin option; plugins are positional arguments, and starting the separate server requires --server. This documented local workflow exits with an unknown-option error.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

+    tooltip_visible=True,
+    tooltip_value_precision=2,


+# Simple candlestick chart
+chart = tvl.candlestick(
+    ohlc_table,
+    time="Timestamp",


+   ```python order=my_chart
+   from deephaven.plot import tradingview_lightweight as tvl
+   t = tvl.data.values()
+   my_chart = tvl.line(t, time="Timestamp", value="Value")


+- **Live Table Support**: Direct integration with real-time Deephaven tables, so charts update as the underlying data ticks.
+- **Viewport-Aware Downsampling**: Pixel-accurate, whitespace-based downsampling that keeps panning and zooming smooth on multi-million-row series.
+- **Server-Side Autobinning**: Histograms compute bin widths and counts directly in the Deephaven query engine, avoiding round-trips of raw data.
+- **Multi-Pane Stacks**: Price, volume, and indicator series can be stacked into separate panes with independent height ratios via `pane_index`.


+  setupFilesAfterEach: [
+    ...(baseConfig.setupFilesAfterEach ?? []),
+    path.join(__dirname, 'jest.setup.ts'),
+  ],
+  setupFiles: [
+    ...(baseConfig.setupFiles ?? []),
+    path.join(__dirname, 'jest.setup.ts'),
+  ],


+  cp -rf "$PLUGIN_ROOT/src/js/dist/." "$DEST"/
+  echo "[e2e] synced freshly built JS bundle into the installed package"


    "update-dh-packages:ui": "npm run update-dh-packages -- --scope=@deephaven/js-plugin-ui --",
    "validate-marketplace": "node tools/validate-marketplace.mjs",
-    "update-doc-snapshots": "./tools/run_docker.sh ./docker-compose.docs-snapshots.yml deephaven-plugins-docs-snapshotter",
+    "update-doc-snapshots": "docker compose -f ./docker/python/docker-compose.yml build server && (./tools/run_docker.sh ./docker-compose.docs-snapshots.yml deephaven-plugins-docs-image-snapshotter-tvl; ec=$?; ./tools/run_docker.sh ./docker-compose.docs-snapshots.yml deephaven-plugins-docs-error-reporter || true; exit $ec)",


+if ! node /work/dist/validate-assets-cli.js "${SNAPSHOTS_HOST_DIR}"; then
+    VALIDATE_EXIT=$?
+    echo "[entrypoint] snapshot asset validation failed (exit ${VALIDATE_EXIT})." >&2
+    # Prefer reporting the playwright failure if there was one, otherwise
+    # surface the validator's exit code.
+    if [ "${PLAYWRIGHT_EXIT}" = "0" ]; then
+        exit "${VALIDATE_EXIT}"
+    fi
+fi


+    let raw: string;
+    try {
+      raw = readFileSync(full, 'utf8');
+    } catch {
+      continue;
+    }
+    let parsed: { objects?: Record<string, ObjEntry> };
+    try {
+      parsed = JSON.parse(raw);
+    } catch {
+      continue;
+    }


+
+### Build the docs locally
+
+From the repo root:


dsmmcken and others added 30 commits April 11, 2026 10:56

TVL init

90bab84

more tvl changes, downsample working closer, but doesn't double click…

a8b5262

… restore correctly.

semi functional downsample

733b5fd

discconnect and downsample improvements, still buggy

762c460

whitespace downsample works okay

62c568e

docs plan

c90e4f1

purge old notes

6a2224c

Co-authored-by: Copilot <copilot@github.com>

autobin histogram

f45886b

5.2

31bbd5b

yolo

0319753

more wip, adding events and timezone.

97c7514

Merge branch 'main' into dmckenzie_tvl

0b4136e

# Conflicts: # package-lock.json # package.json # tests/app.d/tests.app

fix some downsample iissues

4925fe9

events + humanize

d08e407

Merge remote-tracking branch 'origin/main' into dmckenzie_tvl

41cc6c9

# Conflicts: # package-lock.json # tests/app.d/tests.app

fix: migrate tests app.d script to current tvl chart API

6641a74

*_series constructors and chart-level kwargs on per-type constructors were removed; compose via tvl.chart(...) instead. Fixes server startup crash in e2e docker container. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

fix: dump server logs on local e2e failure before compose down remove…

2bb4d7f

…s them Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

chore: ignore python bytecode artifacts

24dfecf

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

update snapshot tests

cfcdcdc

Merge remote-tracking branch 'origin/main' into dmckenzie_tvl

e167d9e

e2e fixes

75b9f9e

passing tests?

b997248

Merge remote-tracking branch 'origin/main' into dmckenzie_tvl

f2d0b16

# Conflicts: # tests/app.d/tests.app

e2e failures

ef9ae2b

lots of review improvements

8e0f8be

Merge remote-tracking branch 'origin/main' into jnumainville_tvl

bd7cfde

fixes

a518b73

fix attempt

6fc31f5

continuousness

0b97f5f

jnumainville requested review from dsmmcken and mofojed August 24, 2026 17:25

jnumainville added 2 commits August 24, 2026 13:07

more continuous charts

c895c3a

more custom rendering

2000eaa

test fixes

9a3fc1f

text fix I really hope

d6e0cba

jnumainville marked this pull request as ready for review August 25, 2026 19:09

Copilot AI balanced review requested due to automatic review settings August 25, 2026 19:09

github-actions Bot requested a review from margaretkennedy August 25, 2026 19:09

Copilot started reviewing on behalf of jnumainville August 25, 2026 19:09 View session

Copilot AI reviewed Aug 25, 2026

View reviewed changes

		cp -rf "$PLUGIN_ROOT/src/js/dist/." "$DEST"/
		echo "[e2e] synced freshly built JS bundle into the installed package"

Uh oh!

Conversation

jnumainville commented Aug 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 20, 2026

Uh oh!

github-actions Bot commented Aug 20, 2026

Uh oh!

github-actions Bot commented Aug 20, 2026

Uh oh!

github-actions Bot commented Aug 20, 2026

Uh oh!

github-actions Bot commented Aug 20, 2026

Uh oh!

github-actions Bot commented Aug 20, 2026

Uh oh!

github-actions Bot commented Aug 20, 2026

Uh oh!

github-actions Bot commented Aug 24, 2026

Uh oh!

github-actions Bot commented Aug 24, 2026

Uh oh!

github-actions Bot commented Aug 24, 2026

Uh oh!

github-actions Bot commented Aug 25, 2026

Uh oh!

github-actions Bot commented Aug 25, 2026

Uh oh!

github-actions Bot commented Aug 25, 2026

Uh oh!

github-actions Bot commented Aug 25, 2026

Uh oh!

github-actions Bot commented Aug 25, 2026

Uh oh!

github-actions Bot commented Aug 25, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jnumainville commented Aug 19, 2026 •

edited

Loading