Skip to content

feat: DH-23433: Added barrage client benchmarks - #430

Open
stanbrub wants to merge 2 commits into
deephaven:mainfrom
stanbrub:barrage-client-benchmarks
Open

feat: DH-23433: Added barrage client benchmarks#430
stanbrub wants to merge 2 commits into
deephaven:mainfrom
stanbrub:barrage-client-benchmarks

Conversation

@stanbrub

Copy link
Copy Markdown
Collaborator

Added a barrage client benchmark to standard benchmarks that measures throughput for a two column table (String, double) retrieved via snapshot

@stanbrub stanbrub self-assigned this Aug 20, 2026
@stanbrub
stanbrub requested review from cpwright and a balanced review from Copilot August 20, 2026 23:37

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a standard benchmark measuring Barrage snapshot throughput for a two-column table.

Changes:

  • Creates a Barrage client session.
  • Benchmarks static snapshot retrieval at scale.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/it/java/io/deephaven/benchmark/tests/standard/client/BarrageClientTest.java Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings August 21, 2026 02:05

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Suppressed comments (1)

src/it/java/io/deephaven/benchmark/tests/standard/client/BarrageClientTest.java:26

  • b's/source' is a scope ticket for the newly opened Barrage session, not for the Bench console session that loaded source. Because these are separate server sessions, the Barrage session has no source variable and this snapshot will fail instead of producing benchmark data. Publish the table under a shared ticket (or otherwise export it into the Barrage session) and snapshot that ticket.
        var q = "result = session.snapshot(b's/source')";

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants