Add external diff tool support - #1048
Open
eagafonov wants to merge 1 commit into
Open
Conversation
Add --external-diff flag and HELM_DIFF_TOOL env var to render diffs with an external command. Manifests are written to two temp files whose paths are appended as the last two arguments. Secret redaction and line suppression stay in effect since manifests are reconstructed from the report entries. Exit code 1 (differences found) is ignored; other failures report to stderr without aborting helm-diff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add --external-diff flag and HELM_DIFF_TOOL env var to render diffs with an external command.
Manifests are written to two temp files whose paths are appended as the last two arguments.
Secret redaction and line suppression stay in effect since manifests are reconstructed from the report entries.
Exit code 1 (differences found) is ignored; other failures report to stderr without aborting helm-diff.
The patch addresses #638