Tune the homepage hero animation timing - #132
Draft
andrewgolovanov wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The hero took too long to reach the final app preview. Applying a global speed multiplier made JavaScript waits finish before the corresponding CSS and timer-driven effects, allowing the prototype cleanup to interrupt the polished app reveal.
Impact
The hero now reaches its final frame in about 12.7 seconds on both desktop and mobile. The final prototype-to-polished transition remains continuous, with no layout, content, or responsive changes.
Validation
pnpm --ignore-workspace run fmtpnpm --ignore-workspace run typecheckpnpm --ignore-workspace run verify:imagespnpm --ignore-workspace exec fallow dead-codepnpm --ignore-workspace exec fallow dupespnpm --ignore-workspace run buildpnpm --ignore-workspace exec playwright test tests/e2e/navigation.spec.ts --grep "home hero animation"pnpm --ignore-workspace run testreaches 323/325 Vitest checks; two generated AppKit documentation link checks fail outside this diff