air: re-land air logs --download-to (restore #6153) - #6259
Merged
Conversation
#6153 ("AIR CLI Migration: --download-to flag for logs") was merged into air-cli on 2026-08-06, but air-cli was later rewound to 1fcb3c0 before #6239 merged, so its implementation was dropped from the branch: air-cli still carried the "--download-to is not implemented yet" stub and lacked logdownload.go and the logs-download acceptance test. This restores #6153's change set onto the current air-cli tip (cherry-pick of the original squash commit). The only file that differs from the original is logstream.go, which is re-merged against #6241's later edits to that file; all other files are identical to #6153. Co-authored-by: Isaac
Collaborator
Integration test reportCommit: e35a501
8 interesting tests: 4 RECOVERED, 4 SKIP
|
ben-hansen-db
approved these changes
Aug 12, 2026
ben-hansen-db
left a comment
ben-hansen-db
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Re-approving commit I had previously approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#6153 ("AIR CLI Migration:
--download-toflag for logs") was lost fromair-cli. It merged on 2026-08-06, butair-cliwas later rewound to1fcb3c09abefore #6239 merged (08-12), and the rebuilt line (#6239 → #6244 → #6241) bypassed #6153. As a resultair-clitoday still carries the pre-#6153 stub:logs.go:--download-to is not implemented yet(the flag is rejected)logdownload.go/logdownload_test.goacceptance/experimental/air/logs-download/test dirThis PR restores #6153's change set onto the current
air-clitip.How
Cherry-pick of #6153's original squash commit (
60cd876910cd) ontoair-cli. Verified equivalence to the original:logstream.gois byte-identical to what AIR CLI Migration: --download-to flag for logs #6153 landed.logstream.gois re-merged against AIR CLI: bringair runsubmit output to parity with the Python CLI #6241's later edits to that file (git auto-merged it cleanly; both changes coexist).Testing
go build ./experimental/air/...— okgo test ./experimental/air/...— 548 passgo test ./acceptance -run TestAccept/experimental/air— 29 pass (incl.logsand the restoredlogs-download)--download-to is not implementedstub is gone andlogs.gonow wires the real implementationThis pull request and its description were written by Isaac.