Skip to content

fix: Hard fail if the secret is not a string - #6212

Merged
andrewnester merged 4 commits into
mainfrom
fix/validate-secret-hard-fail
Aug 12, 2026
Merged

fix: Hard fail if the secret is not a string#6212
andrewnester merged 4 commits into
mainfrom
fix/validate-secret-hard-fail

Conversation

@andrewnester

Copy link
Copy Markdown
Contributor

Changes

Hard fail if the secret is not a string

Tests

Existing tests pass

Comment thread bundle/config/mutator/validate_secret_value_is_variable.go
@eng-dev-ecosystem-bot

Copy link
Copy Markdown
Collaborator

Integration test report

Commit: ac36b76

Run: 31386223681

Env 🔄​flaky 💚​RECOVERED 🙈​SKIP ✅​pass 🙈​skip Time
💚​ aws linux 4 4 294 1122 10:12
💚​ aws windows 4 4 296 1120 7:45
💚​ azure linux 4 4 293 1122 11:13
💚​ azure windows 4 4 295 1120 7:29
💚​ gcp linux 1 5 294 1122 10:17
🔄​ gcp windows 1 1 5 295 1120 10:12
9 interesting tests: 4 RECOVERED, 4 SKIP, 1 flaky
Test Name aws linux aws windows azure linux azure windows gcp linux gcp windows
💚​ TestAccept 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
🙈​ TestAccept/bundle/invariant/no_drift 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
🙈​ TestAccept/bundle/resources/vector_search_endpoints/drift/recreated_same_name 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
🙈​ TestAccept/bundle/resources/vector_search_indexes/recreate/embedding_dimension 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
🙈​ TestAccept/ssh/connection 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
🔄​ TestSyncNestedFolderDoesntFailOnNonEmptyDirectory ✅​p ✅​p ✅​p ✅​p ✅​p 🔄​f
💚​ TestFetchRepositoryInfoAPI_FromRepo 💚​R 💚​R 💚​R 💚​R 🙈​S 🙈​S
💚​ TestFetchRepositoryInfoAPI_FromRepo/root 💚​R 💚​R 💚​R 💚​R
💚​ TestFetchRepositoryInfoAPI_FromRepo/subdir 💚​R 💚​R 💚​R 💚​R
Top 14 slowest tests (at least 2 minutes):
duration env testname
4:20 gcp windows TestAccept
4:18 azure windows TestAccept
3:28 aws windows TestAccept
3:12 gcp linux TestImportDirWithOverwriteFlag
2:57 azure linux TestImportDir
2:34 gcp windows TestLock
2:22 azure windows TestFilerWorkspaceFilesExtensionsRead
2:18 azure linux TestFilerWorkspaceFilesExtensionsStat
2:17 azure linux TestFilerWorkspaceFilesExtensionsReadDir
2:14 aws windows TestFilerWorkspaceFilesExtensionsStat
2:12 aws linux TestFilerWorkspaceFilesExtensionsReadDir
2:08 gcp linux TestFilerRecursiveDelete/workspace_files
2:08 azure windows TestFilerWorkspaceFilesExtensionsReadDir
2:07 gcp windows TestSyncFullFileSync

@andrewnester
andrewnester enabled auto-merge August 10, 2026 14:28
if !ok {
continue
}
valueStr := val.MustString()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend keeping this. The guard above only checks if the key exists or not. It doesn't exist because of normalization. If we ever change that, this statement will hard panic.

@pietern
pietern disabled auto-merge August 12, 2026 07:52
@andrewnester
andrewnester enabled auto-merge August 12, 2026 14:23
@andrewnester
andrewnester disabled auto-merge August 12, 2026 14:29
@andrewnester
andrewnester merged commit 4e2973d into main Aug 12, 2026
21 of 22 checks passed
@andrewnester
andrewnester deleted the fix/validate-secret-hard-fail branch August 12, 2026 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants