Fix segfault after delete_records() on Python 3.14 (reference-counting bug) - #2328
Merged
Merged
Conversation
Ojasva Jain (ojasvajain)
requested review from
a team and
Matthew Seal (MSeal)
as code owners
August 17, 2026 06:03
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
|
Pranav Rathi (pranavrth)
approved these changes
Aug 24, 2026
Pranav Rathi (pranavrth)
left a comment
Pranav Rathi (pranavrth)
left a comment
Member
There was a problem hiding this comment.
LGTM!. Thanks Ojasva Jain (@ojasvajain) !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2275
Removed the two spurious Py_XDECREF(topic_partition_offsets) calls. The function should not touch the refcount of an argument it doesn't own.
What
Checklist
References
JIRA:
Test & Review
Open questions / Follow-ups