Skip to content

fix async_uring_cmd not forwarding cqe_handler args #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wokron merged 1 commit into from
Aug 10, 2026
Merged

fix async_uring_cmd not forwarding cqe_handler args #176

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 17 additions & 9 deletions include/condy/async_operations.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -839,10 +839,12 @@ inline auto async_socket_direct(int domain, int type, int protocol,
* @tparam CQEHandler Custom CQE handler for specific result processing.
* @param cmd_func Function to configure sqe for specific command. Signature:
* void(io_uring_sqe *sqe).
* @param handler_args Arguments forwarded to CQEHandler constructor.
*/
template <CQEHandlerLike CQEHandler = SimpleCQEHandler, FdLike Fd,
typename CmdFunc>
inline auto async_uring_cmd(int cmd_op, Fd fd, CmdFunc &&cmd_func) {
typename CmdFunc, typename... Args>
inline auto async_uring_cmd(int cmd_op, Fd fd, CmdFunc &&cmd_func,
Args &&...handler_args) {
auto prep_func = [cmd_op, fd = detail::unwrap_fixed(fd),
cmd_func =
std::forward<CmdFunc>(cmd_func)](detail::Ring *ring) {
Expand All @@ -851,17 +853,19 @@ inline auto async_uring_cmd(int cmd_op, Fd fd, CmdFunc &&cmd_func) {
cmd_func(sqe);
return sqe;
};
auto op = build_op_awaiter<CQEHandler>(std::move(prep_func));
auto op = build_op_awaiter<CQEHandler>(std::move(prep_func),
std::forward<Args>(handler_args)...);
return detail::maybe_flag_fixed_fd(std::move(op), fd);
}

/**
* @copydoc async_uring_cmd
*/
template <CQEHandlerLike CQEHandler = SimpleCQEHandler, FdLike Fd,
typename CmdFunc, typename MultiShotFunc>
typename CmdFunc, typename MultiShotFunc, typename... Args>
inline auto async_uring_cmd_multishot(int cmd_op, Fd fd, CmdFunc &&cmd_func,
MultiShotFunc &&func) {
MultiShotFunc &&func,
Args &&...handler_args) {
auto prep_func = [cmd_op, fd = detail::unwrap_fixed(fd),
cmd_func =
std::forward<CmdFunc>(cmd_func)](detail::Ring *ring) {
Expand All @@ -871,7 +875,8 @@ inline auto async_uring_cmd_multishot(int cmd_op, Fd fd, CmdFunc &&cmd_func,
return sqe;
};
auto op = build_multishot_op_awaiter<CQEHandler>(
std::move(prep_func), std::forward<MultiShotFunc>(func));
std::move(prep_func), std::forward<MultiShotFunc>(func),
std::forward<Args>(handler_args)...);
return detail::maybe_flag_fixed_fd(std::move(op), fd);
}

Expand All @@ -881,10 +886,12 @@ inline auto async_uring_cmd_multishot(int cmd_op, Fd fd, CmdFunc &&cmd_func,
* @tparam CQEHandler Custom CQE handler for specific result processing.
* @param cmd_func Function to configure sqe for specific command. Signature:
* void(io_uring_sqe *sqe).
* @param handler_args Arguments forwarded to CQEHandler constructor.
*/
template <CQEHandlerLike CQEHandler = SimpleCQEHandler, FdLike Fd,
typename CmdFunc>
inline auto async_uring_cmd128(int cmd_op, Fd fd, CmdFunc &&cmd_func) {
typename CmdFunc, typename... Args>
inline auto async_uring_cmd128(int cmd_op, Fd fd, CmdFunc &&cmd_func,
Args &&...handler_args) {
auto prep_func = [cmd_op, fd = detail::unwrap_fixed(fd),
cmd_func =
std::forward<CmdFunc>(cmd_func)](detail::Ring *ring) {
Expand All @@ -896,7 +903,8 @@ inline auto async_uring_cmd128(int cmd_op, Fd fd, CmdFunc &&cmd_func) {
cmd_func(sqe);
return sqe;
};
auto op = build_op_awaiter<CQEHandler>(std::move(prep_func));
auto op = build_op_awaiter<CQEHandler>(std::move(prep_func),
std::forward<Args>(handler_args)...);
return detail::maybe_flag_fixed_fd(std::move(op), fd);
}
#endif
Expand Down
Loading