Lottie storybook - #2469
Merged
Merged
Conversation
Resolve file types via their collection name from the registry instead of going through `Pageflow::BuiltInFileType`, and pick up any attribute ending in `_files`. Plugin defined file types like `lottie_files` can now be seeded without the seeds DSL knowing about them.
Enable the lottie animation feature for the storybook seed account. File types registered inside a feature only end up in the seed's url templates if the feature is enabled for the entry.
Since the element ships as a separate frontend pack, the stories import its own `frontend` module instead of the aggregate content element registry. Storybook's webpack config needs the same rule for the dotLottie WebAssembly module that host applications get via `config/webpack.js`. Lottie files are also included in the collections that inline file rights stories apply rights to.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
REDMINE-21349