fix: strip BOM and whitespace from authorization token - #757
Open
sentry[bot] wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a
UnicodeEncodeErrorthat occurred when the Codecov CLI attempted to send anAuthorizationheader containing a Byte Order Mark (BOM) character (\ufeff).The error, "UnicodeEncodeError: 'latin-1' codec can't encode character '\ufeff'", was triggered because
urllib3(used byrequests) attempts to encode HTTP headers usinglatin-1, which does not support the\ufeffcharacter.The root cause was identified as the token string, often provided via CLI arguments or environment variables, sometimes containing a leading
\ufeffcharacter (e.g., from copy-pasting from certain sources or specific file encodings). The CLI was using this token verbatim when constructing theAuthorizationheader.To fix this, the
get_token_headerandget_token_header_or_failfunctions incodecov_cli/helpers/request.pyhave been updated to strip the\ufeffcharacter and any surrounding whitespace from the token string before it is used to form theAuthorizationheader. This ensures that only valid, encodable characters are passed to the HTTP client.Fixes CLI-EP