chore: Removes unused code - #499
Open
claudiubelu wants to merge 1 commit into
Open
Conversation
- `coriolis/minion_manager/rpc/client.py`: `set_up_shared_minion_pool_resources` and `tear_down_shared_minion_pool_resources` were never tied to anything on the server side. Commit 2599ca8 introduced them as part of a refactor, with the server side commented out, which was later on removed in d20c670. The client side survived, unused. - `/coriolis/minion_manager/rpc/utils.py`: `minion_machine_synchronized` is not referenced. Most minion-related operations use the minion_pool_synchronized_op decorator instead, or minion_manager_utils.get_minion_pool_lock() (e.g.: deallocate_minion_machine). - `coriolis/providers/backup_writers.py`: `_fetch_remote_file` private method, unused. - `coriolis/scheduler/scheduler_utils.py`: not referenced anywhere. - `coriolis/schemas_exceptions.py`: not referenced anywhere. - `coriolis/taskflow/base.py`: private methods, unused. - `coriolis/worker/rpc/server.py`: `_check_remove_dir` private method, unused.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
coriolis/minion_manager/rpc/client.py:set_up_shared_minion_pool_resourcesandtear_down_shared_minion_pool_resourceswere never tied to anything on the server side. Commit 2599ca8 introduced them as part of a refactor, with the server side commented out, which was later on removed in d20c670. The client side survived, unused./coriolis/minion_manager/rpc/utils.py:minion_machine_synchronizedis not referenced. Most minion-related operations use theminion_pool_synchronized_opdecorator instead, orminion_manager_utils.get_minion_pool_lock()(e.g.:deallocate_minion_machine).coriolis/providers/backup_writers.py:_fetch_remote_fileprivate method, unused.coriolis/scheduler/scheduler_utils.py: not referenced anywhere.coriolis/schemas_exceptions.py: not referenced anywhere.coriolis/taskflow/base.py: private methods, unused.coriolis/worker/rpc/server.py:_check_remove_dirprivate method, unused.