Skip to content

refactor(ui): render user button rows with the headless Button - #9403

Merged
alexcarpenter merged 2 commits into
mainfrom
carp/mosaic-item-headless-button
Aug 11, 2026
Merged

refactor(ui): render user button rows with the headless Button#9403
alexcarpenter merged 2 commits into
mainfrom
carp/mosaic-item-headless-button

Conversation

@alexcarpenter

Copy link
Copy Markdown
Member

Description

The rows in the Mosaic UserButton popup stand down while another action runs, and they do it through aria-disabled rather than the native attribute so the row that owns the action keeps its place in the tab order while its spinner is announced. That was a local asButton render helper in user-button.view.tsx, written before the headless Button existed.

The headless Button now owns that behavior, so the rows use it: <Button disabled focusableWhenDisabled /> as Item.Root's render. Alongside dropping the press, the rows now get the pointer-press suppression that actually keeps focus put, Enter/Space neutered while Tab still moves off, and a data-disabled attribute to style against.

One test needed a line. The headless Button prevents pointerdown, and user-event skips mousedown when it is prevented — along with the focus step that lives on it, which had been pulling focus back from the popup's own initial focus. The test now waits for that initial focus to land before the row takes it.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Replaces the hand-rolled disabled-but-focusable row button with the headless Button's focusableWhenDisabled.
@vercel

vercel Bot commented Aug 11, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview Aug 11, 2026 9:32pm
swingset Ready Ready Preview Aug 11, 2026 9:32pm

Request Review

@changeset-bot

changeset-bot Bot commented Aug 11, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 5616d58

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented Aug 11, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9403

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9403

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9403

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9403

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9403

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9403

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9403

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9403

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@9403

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9403

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9403

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9403

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9403

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9403

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9403

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9403

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9403

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9403

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9403

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9403

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9403

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9403

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9403

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9403

commit: 5616d58

@github-actions

github-actions Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-08-11T21:33:51.110Z

Summary

Metric Count
Packages analyzed 19
Packages with changes 0
🔴 Breaking changes 0
🟡 Non-breaking changes 0
🟢 Additions 0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on 5616d58.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The user-button row renderer now uses Clerk Headless Button for workspace and non-link action rows. Disabled rows use focusableWhenDisabled and aria-disabled behavior while navigational actions continue to render as anchors. The focus test waits for dialog initialization before checking focus preservation and action suppression. A patch changeset was added.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: austincalvelage, maxyinger

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the primary change: rendering UserButton popup rows with the headless Button.
Description check ✅ Passed The description directly explains the row refactor, preserved focus behavior, disabled handling, and related test update.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.changeset/mosaic-user-button-headless-row.md:
- Around line 1-2: Add a valid Changeset entry in the file by declaring the
package from packages/ui/package.json with a patch bump and including a concise
release note describing the UserButton change; retain the required Changeset
frontmatter delimiters.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: d9c5a19d-cf42-46e4-b20c-f2854e1859dc

📥 Commits

Reviewing files that changed from the base of the PR and between 81840b3 and 84af1c8.

📒 Files selected for processing (3)
  • .changeset/mosaic-user-button-headless-row.md
  • packages/ui/src/mosaic/user-button/__tests__/user-button.view.test.tsx
  • packages/ui/src/mosaic/user-button/user-button.view.tsx
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • clerk/clerk_go (manual)
  • clerk/dashboard (manual)
  • clerk/accounts (manual)
  • clerk/backoffice (manual)
  • clerk/clerk (manual)
  • clerk/clerk-docs (manual)
  • clerk/cloudflare-workers (manual)
  • clerk/cli (auto-detected)
  • clerk/clerk-ios (auto-detected)
  • clerk/clerk-android (auto-detected)

Comment on lines +1 to +2
---
---

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

Add the packages/ui patch entry.

This file contains only Changeset delimiters. It does not declare a package, a patch bump, or a release note. Add the patch entry for the package defined by packages/ui/package.json and describe this UserButton change.

As per coding guidelines, “Use Changesets for managing releases.” The PR objective also requires a patch changeset for this packages/ui change.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.changeset/mosaic-user-button-headless-row.md around lines 1 - 2, Add a
valid Changeset entry in the file by declaring the package from
packages/ui/package.json with a patch bump and including a concise release note
describing the UserButton change; retain the required Changeset frontmatter
delimiters.

Source: Coding guidelines

@alexcarpenter
alexcarpenter enabled auto-merge (squash) August 11, 2026 21:40
@alexcarpenter
alexcarpenter merged commit f75cb93 into main Aug 11, 2026
52 checks passed
@alexcarpenter
alexcarpenter deleted the carp/mosaic-item-headless-button branch August 11, 2026 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants