Fixed hub install aborting when there is no PostgreSQL backup to preserve - #2398
Open
nickanderson wants to merge 1 commit into
Open
Fixed hub install aborting when there is no PostgreSQL backup to preserve#2398nickanderson wants to merge 1 commit into
nickanderson wants to merge 1 commit into
Conversation
nickanderson
force-pushed
the
ENT-11934/master
branch
2 times, most recently
from
August 5, 2026 16:53
7e68b0d to
5c357a2
Compare
craigcomstock
approved these changes
Aug 5, 2026
craigcomstock
left a comment
craigcomstock
left a comment
Contributor
There was a problem hiding this comment.
seems reasonable, try it through a full jenkins run maybe?
…erve init_postgres_dir() took the "preserve the old pg_*.conf" branch on any upgrade, but preinstall.sh only populates $BACKUP_DIR/data when a PostgreSQL major version migration is needed and $PREFIX/state/pg/data exists. Upgrading within a major version, or after removing the data directory as preinstall.sh suggests to skip the migration, made the glob match nothing and aborted the whole scriptlet under `set -e`. Ticket: ENT-11934 Changelog: title
nickanderson
force-pushed
the
ENT-11934/master
branch
from
August 5, 2026 17:56
5c357a2 to
95483d5
Compare
Member
Author
|
Converted the comment into a @cf-bottom jenkins please |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/14396/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-14396/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hub postinstall took the "preserve the old pg_*.conf" branch on any upgrade, but
preinstall.shonly makes that backup for a PostgreSQL major version migration with an existing data directory. Without one the glob matched nothing and aborted the scriptlet underset -e.Ticket: ENT-11934