SP-1173: decide CUI marking from the cover response status - #414
Open
Dennis Woditsch (dwoditsch) wants to merge 3 commits into
Open
Conversation
The cover response categories no longer take part in the decision: 403 leaves the artifact untouched, 204 marks it Unclassified, and 200 marks it CUI and attaches the cover sheet. Anything else fails the command without writing output. Includes-AI-Code: true Co-authored-by: Cursor <cursoragent@cursor.com>
Unclassified is now reached through 204 and classified through 200, so the specs drop the category fixtures. The shared mock answers 403 so unrelated tests keep their original filenames. Includes-AI-Code: true Co-authored-by: Cursor <cursoragent@cursor.com>
The command specs only exercised classified writes, so the 204 branch was reached by the unit spec alone. Each artifact shape now has an unclassified case, and a failing cover call is asserted to abort the command without producing a file. Includes-AI-Code: true Co-authored-by: Cursor <cursoragent@cursor.com>
Dennis Woditsch (dwoditsch)
marked this pull request as ready for review
August 12, 2026 13:06
Dennis Woditsch (dwoditsch)
requested review from
a team,
andyo (aocelo) and
Siavash Safaei (siavash-celonis)
as code owners
August 12, 2026 13:06
Dennis Woditsch (dwoditsch)
force-pushed
the
feat/SP-1173-cui-cover-response-semantics
branch
from
August 12, 2026 14:07
2046992 to
4c83459
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stacked on #413.
The CUI cover call now decides the outcome by status code only.
resolvedCuiMarking.categoriesis no longer read anywhere, so a team that has CUI on but no matching categories gets anUnclassified - …artifact through the 204 path instead of an unmarked one.list packages --json)packages.jsonUnclassified - packages.jsonCUI - packages.zipcontainingpackages.jsonandCUI_Cover_Sheet.pdfWhat changed against the previous behaviour:
CuiApireturns adisabled/unclassified/classifieddecision instead of a nullable cover body, andCuiFileServiceswitches on it.isClassifiedand every category check are gone. Failures still fail closed: the command errors and no artifact is left behind.docs/cui-marking.mdis updated to the three status rows.Relevant links
Checklist
Made with Cursor