host: Update two test modules with multi-realm index cache - #5737
Draft
backspace wants to merge 1 commit into
Draft
host: Update two test modules with multi-realm index cache#5737backspace wants to merge 1 commit into
backspace wants to merge 1 commit into
Conversation
operator-mode-acceptance (4.09m) and ai-assistant-panel/tools (3.84m) each build two realms per test with identical fixtures, in a shared beforeEach, so they qualify for the multi-realm path: an explicit capture after the second realm, since the automatic one lands after the first and would omit the other. These are the only two of the eight remaining multi-realm candidates that fit. The rest divide into two groups, neither of which belongs here: host-submode, code-submode, card-playground build realms inside nested modules, and card-copy builds one inside a test body — so those realms exist for only some tests, which the snapshot cannot represent. The guard rejects them rather than serving an empty index. inspector, create-file, card-playground and code-submode already cache their realm setup through `withCachedRealmSetup`, which restores the snapshot and then still runs setup, leaving the boot index a no-op instead of skipping it. That tolerates realms some tests don't build, and keeps the loader bookkeeping that `skipBootIndex` omits — the same bookkeeping two store tests needed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.