host: Add index reuse to split store tests - #5729
Open
backspace wants to merge 1 commit into
Open
Conversation
Contributor
Preview deploymentsHost Test Results 1 files 1 suites 2h 7m 21s ⏱️ Results for commit 5e83405. Realm Server Test Results 1 files ±0 1 suites ±0 13m 39s ⏱️ -18s Results for commit 5e83405. ± Comparison against earlier commit b88542a. |
backspace
force-pushed
the
store-module-rebuild-split
branch
3 times, most recently
from
August 10, 2026 13:23
3899539 to
0fa7b68
Compare
backspace
force-pushed
the
shared-index-multirealm
branch
from
August 11, 2026 13:01
cba0b73 to
73b0575
Compare
backspace
force-pushed
the
store-module-rebuild-split
branch
from
August 11, 2026 13:04
eac049d to
b88542a
Compare
store-test.gts is the suite's largest file (6.78m over 73 tests) and, once the interact-submode family reuses its index, the file that pins the slowest shard — so migrating it is the only remaining change that shortens CI rather than just using less runner time. It couldn't opt in because two of its tests assert on what a source write does to the *loader*: that the write flushed the module out, and that the flush was recorded. A test whose index was restored runs against a realm started with `skipBootIndex`, so no fixture module was ever loaded for a write to invalidate or a flush to record, and both preconditions fail. Those two belong to a coherent group of twelve — executable invalidation, rebuild telemetry, flush records — which all read the loader's reaction to a code change rather than the Store's handling of data. Moving the whole group to store-module-rebuild-test.gts, rather than only the two that happened to fail, keeps the concern in one place and stops a sibling from quietly depending on the boot index later. They carry their own three helpers (countRebuilds, renderCard, captureTelemetry) and a fixture set cut to what they use: Person, Employee, and one instance, in place of the parent's four classes and nine files. store-test.gts keeps 61 tests and now reuses its index. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
backspace
force-pushed
the
store-module-rebuild-split
branch
from
August 11, 2026 16:04
b88542a to
5e83405
Compare
backspace
marked this pull request as ready for review
August 11, 2026 17:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in the vein of #5722, but the file needed to be broken up.