Fix Programmatic Usage section in cds-feature-ai-core README - #130
Merged
lisajulia merged 1 commit intoAug 13, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
The README update is accurate — all context class names, method signatures, and the RemoteService-based service lookup match the actual Java source. The only substantive issue flagged is that the short "Programmatic API" snippet under the "CDS Service: AICore" section references aiCoreService without declaring it, leaving readers with an incomplete, non-compilable example.
PR Bot Information
Version: 1.29.26
- File Content Strategy: Full file content
- LLM:
anthropic--claude-4.6-sonnet - Correlation ID:
6cfffe60-968c-11f1-84fd-a0637dd0570d - Event Trigger:
pull_request.opened
agoerler
approved these changes
Aug 13, 2026
lisajulia
deleted the
fix/cds-feature-ai-core-README-Programmmatic-Usage
branch
August 13, 2026 08:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Programmatic Usage Section in
cds-feature-ai-coreREADMEDocumentation
📝 Updated the
Programmatic Usagesection in thecds-feature-ai-coreREADME to reflect the correct event-driven API usage instead of outdated direct method calls.Changes
cds-feature-ai-core/README.md:AICoreService-typed direct method calls (resourceGroup(),deploymentId(),inferenceClient()) with the correct CDS event-based pattern using context objects (ResourceGroupContext,DeploymentIdContext,InferenceClientContext).ResourceGroupContextandDeploymentIdContextviaaiCoreService.emit(...).RemoteService(instead ofAICoreService) and to resolve resource group, deployment, and inference client through CDS events.ApiClientto referenceInferenceClientContextinstead of the oldinferenceClient()method.RecommendationConfiguration.javaas a real-world usage example.PR Bot Information
Version:
1.29.26anthropic--claude-4.6-sonnet6cfffe60-968c-11f1-84fd-a0637dd0570dpull_request.opened