Skip to content

Fix Programmatic Usage section in cds-feature-ai-core README - #130

Merged
lisajulia merged 1 commit into
mainfrom
fix/cds-feature-ai-core-README-Programmmatic-Usage
Aug 13, 2026
Merged

Fix Programmatic Usage section in cds-feature-ai-core README#130
lisajulia merged 1 commit into
mainfrom
fix/cds-feature-ai-core-README-Programmmatic-Usage

Conversation

@lisajulia

@lisajulia lisajulia commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Fix Programmatic Usage Section in cds-feature-ai-core README

Documentation

📝 Updated the Programmatic Usage section in the cds-feature-ai-core README to reflect the correct event-driven API usage instead of outdated direct method calls.

Changes

  • cds-feature-ai-core/README.md:
    • Replaced deprecated AICoreService-typed direct method calls (resourceGroup(), deploymentId(), inferenceClient()) with the correct CDS event-based pattern using context objects (ResourceGroupContext, DeploymentIdContext, InferenceClientContext).
    • Updated the Programmatic API section (under service overview) to use ResourceGroupContext and DeploymentIdContext via aiCoreService.emit(...).
    • Rewrote the Programmatic Usage section to obtain the service as a RemoteService (instead of AICoreService) and to resolve resource group, deployment, and inference client through CDS events.
    • Fixed the description of ApiClient to reference InferenceClientContext instead of the old inferenceClient() method.
    • Added a reference to RecommendationConfiguration.java as a real-world usage example.
  • 🔄 Regenerate and Update Summary
PR Bot Information

Version: 1.29.26

  • Output Template: Default Template
  • LLM: anthropic--claude-4.6-sonnet
  • Correlation ID: 6cfffe60-968c-11f1-84fd-a0637dd0570d
  • Event Trigger: pull_request.opened
  • Summary Prompt: Default Prompt
  • File Content Strategy: Full file content

@hyperspace-pr-bot hyperspace-pr-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README update is accurate — all context class names, method signatures, and the RemoteService-based service lookup match the actual Java source. The only substantive issue flagged is that the short "Programmatic API" snippet under the "CDS Service: AICore" section references aiCoreService without declaring it, leaving readers with an incomplete, non-compilable example.

PR Bot Information

Version: 1.29.26

  • File Content Strategy: Full file content
  • LLM: anthropic--claude-4.6-sonnet
  • Correlation ID: 6cfffe60-968c-11f1-84fd-a0637dd0570d
  • Event Trigger: pull_request.opened

Comment thread cds-feature-ai-core/README.md
@lisajulia
lisajulia requested a review from agoerler August 12, 2026 20:31
@lisajulia
lisajulia merged commit e614063 into main Aug 13, 2026
10 checks passed
@lisajulia
lisajulia deleted the fix/cds-feature-ai-core-README-Programmmatic-Usage branch August 13, 2026 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants