fix(jest): report skipped tests correctly - #182
Merged
Conversation
|
@mrousavy is attempting to deploy a commit to the Callstack Team on Vercel. A member of the Team first needs to authorize it. |
mrousavy
marked this pull request as ready for review
August 5, 2026 15:30
V3RON
approved these changes
Aug 6, 2026
V3RON
left a comment
V3RON
left a comment
Contributor
There was a problem hiding this comment.
Verified: the fix correctly maps 'skipped' to 'pending' status, matching Jest's own pattern. Both declaration-time (it.skip) and runtime (context.skip) skips are handled properly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this?
This fixes skipped Harness tests being rendered as successful tests in Jest's verbose output. Both declaration-time skips (
it.skip) and runtime skips (context.skip) now use Jest's skipped treatment.How does it work?
Harness keeps its internal
skippedstatus and translates it to Jest's publicpendingassertion status at the Jest adapter boundary. The mapping is applied to both live test-case events and final file results, using Jest's supported result APIs without patching Jest or Vitest.Why is this useful?
CI output and Jest-compatible result consumers no longer present skipped tests as passing, making test reports accurate and immediately understandable.