Add a more comprehensive python deps test - #2675
Merged
Merged
Conversation
Instead of just verifying the versions are valid for an individual plugin, build a directory structure containing a plugin and its dependencies and attempt to resolve everything together. This catches issues like #2674 and also validates the requires-python values. The requires-python validation caught two issues in mypy plugins at the latest version.
emcfarlane
approved these changes
Aug 21, 2026
pkwarren
commented
Aug 21, 2026
pkwarren
left a comment
Member
Author
There was a problem hiding this comment.
The test would've caught the previous issue:
--- FAIL: TestPyPIDependencies (1.91s)
--- FAIL: TestPyPIDependencies/connectrpc/py@v0.11.1 (0.03s)
plugins_test.go:506:
Error Trace: /Users/pkw/dev/plugins/tests/plugins_test.go:506
Error: Received unexpected error:
exit status 1
Test: TestPyPIDependencies/connectrpc/py@v0.11.1
Messages: uv lock failed - output: Using CPython 3.13.2
× No solution found when resolving dependencies:
╰─▶ Because connectrpc>=0.11.1 depends on protobuf-py==0.1.1 and
bufbuild-py==0.2.0 depends on protobuf-py>=0.2.0, we can conclude that
bufbuild-py==0.2.0 and connectrpc>=0.11.1 are incompatible.
And because only bufbuild-py==0.2.0 is available, we can conclude that
all versions of bufbuild-py and connectrpc>=0.11.1 are incompatible.
And because your project depends on bufbuild-py and connectrpc>=0.11.1,
we can conclude that your project's requirements are unsatisfiable.
| # https://github.com/nipunn1313/mypy-protobuf/blob/v5.1.0/pyproject.toml#L21 | ||
| requires_python: ">=3.8" | ||
| # Bumped to match protobuf requirement. | ||
| requires_python: ">=3.9" |
Member
Author
There was a problem hiding this comment.
The protobuf version below requires 3.9 so needed to bump these.
oliversun9
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of just verifying the versions are valid for an individual plugin, build a directory structure containing a plugin and its dependencies and attempt to resolve everything together. This catches issues like #2674 and also validates the requires-python values. The requires-python validation caught two issues in mypy plugins at the latest version.