Skip to content

ci: run lint on Node.js 22 - #3714

Merged
charmander merged 1 commit into
brianc:masterfrom
noritaka1166:ci/use-node-22-for-lint
Aug 11, 2026
Merged

ci: run lint on Node.js 22#3714
charmander merged 1 commit into
brianc:masterfrom
noritaka1166:ci/use-node-22-for-lint

Conversation

@noritaka1166

@noritaka1166 noritaka1166 commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Update the Node.js version used by the lint job from 18 to 22.

Rationale

The repository uses ESLint 10.2.1, which requires Node.js
^20.19.0 || ^22.13.0 || >=24.

The lint job was still running on Node.js 18 and failed before reporting lint
results because util.styleText is unavailable in that runtime.

Follow-up

Running lint with Node.js 22 exposed an existing TypeScript lint issue:

packages/pg-query-stream/src/index.ts:75
'QueryStream' is already defined  no-redeclare

It is caused by the intentional QueryStream class/namespace declaration merge used to expose
QueryStream.Config.
This will be addressed in a separate follow-up PR.

@brianc

brianc commented Jul 21, 2026

Copy link
Copy Markdown
Owner

thanks! i merged yer other PR

@charmander
charmander force-pushed the ci/use-node-22-for-lint branch from 372a001 to 712a4be Compare August 11, 2026 06:12
@charmander
charmander merged commit 6f1cf81 into brianc:master Aug 11, 2026
12 checks passed
@noritaka1166
noritaka1166 deleted the ci/use-node-22-for-lint branch August 11, 2026 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants