Add Verda validation, remove cron for other validations, move to specific validation run - #145
Merged
Conversation
Contributor
|
does it make sense to only run these after merge like we do for the e2e on dev-plane? And enforce that new ones queue behind old ones instead of cancelling? |
patelspratik
approved these changes
Aug 14, 2026
Contributor
Author
Yeah that's a good idea and points us to needing to formalize exactly which git shas are appropriate for pulling into devplane. One method could be that it's just the honor system. Another is that these runs occur on a non-main branch, and the merge to main is only done as a mark of validation/release candidacy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests are vital, but also are at the whims of git pushes and overlapping cron/PRs, and thus result in lots of orphaned data.
Going forward, we should be very explicit about running these actions, as they ultimately consume both capacity and funds.