Skip to content

fix: Calculate Verda GPU VRAM as Per GPU #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
drewmalin merged 1 commit into from
Aug 14, 2026
+24 −1
Merged

fix: Calculate Verda GPU VRAM as Per GPU #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions v1/providers/verda/client_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,27 @@ func TestWrapVerdaInsufficientResourcesError(t *testing.T) {
assert.False(t, errors.Is(err, v1.ErrServiceUnavailable))
}

func TestVerdaInstanceTypeUsesPerGPUMemory(t *testing.T) {
instanceType, err := verdaInstanceTypeToInstanceType(verdago.InstanceTypeInfo{
InstanceType: "8V100.128G",
Model: "V100 16GB",
GPU: verdago.InstanceGPU{
NumberOfGPUs: 8,
},
GPUMemory: verdago.InstanceMemory{
SizeInGigabytes: 128,
},
PricePerHour: 1,
Currency: "usd",
}, "FIN-01")
require.NoError(t, err)
require.Len(t, instanceType.SupportedGPUs, 1)

gpu := instanceType.SupportedGPUs[0]
assert.Equal(t, int32(8), gpu.Count)
assert.Equal(t, v1.NewBytes(16, v1.Gigabyte), gpu.MemoryBytes)
}

func TestGetInstanceTypesAndLocations(t *testing.T) { //nolint:funlen // One catalog fixture exercises all shared validations.
server := newVerdaTestServer(t, func(w http.ResponseWriter, r *http.Request) {
switch r.URL.Path {
Expand Down
4 changes: 3 additions & 1 deletion v1/providers/verda/instancetype.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,9 @@ func verdaInstanceTypeToInstanceType(verdaType verdago.InstanceTypeInfo, locatio
}

if verdaType.GPU.NumberOfGPUs > 0 {
gpuMemory, gpuMemoryBytes := byteSizes(int64(verdaType.GPUMemory.SizeInGigabytes), v1.Gigabyte)
// The Verda API does not expose the GPU memory per GPU, so we need to calculate it
gpuMemoryGB := int64(verdaType.GPUMemory.SizeInGigabytes) / int64(verdaType.GPU.NumberOfGPUs)
gpuMemory, gpuMemoryBytes := byteSizes(gpuMemoryGB, v1.Gigabyte)
gpuModel := strings.ToUpper(strings.TrimSpace(verdaType.Model))
instanceType.SupportedGPUs = []v1.GPU{{
Count: int32(verdaType.GPU.NumberOfGPUs), //nolint:gosec // ok
Expand Down
Loading