fix(refresh): preserve host SSH route - #444
Open
jyaunches wants to merge 1 commit into
Open
Conversation
Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>
This was referenced Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NemoClaw workflow blocker: NVIDIA/NemoClaw#8924
Summary
Problem
PR #424 changed refresh to resolve normal workspace SSH through the SSH access and network APIs. That path also rewrote
HostSSHHostnamefrom the existing Brev gateway hostname to a provider public IP and clearedHostSSHProxyHostname.The rewrite retained the existing
HostSSHPort. For the reproduced GCP environments, that port is allocated on the Brev gateway, not on the raw provider IP. The resulting<workspace>-hosttarget timed out before SSH authentication.This blocks NVIDIA/NemoClaw's trusted
Exact staging Brev Launchablejob. The workflow requiresbrev exec --hostto verify the exact boot image and baked runtime before it runs the full E2E suite. See NVIDIA/NemoClaw#8924.Fix
resolveWorkspaceSSHnow updates only the normal workspace SSH fields:SSHHostnameSSHPortSSHUserSSHProxyHostnameIt leaves the existing
HostSSH*route from the workspace inventory unchanged. The regression test starts with a distinct host gateway, mapped port, user, and proxy. The test requires all host fields to remain unchanged after normal SSH enrichment.Live validation
The comparison used two existing environments created from separate Launchables that point to the same GCP image family. Both environments booted the expected concrete image.
-hosttargetbrev exec --hostv0.6.330v0.6.334v0.6.334sourceThe patched binary also read the expected GCE boot-image URI and NemoClaw provision receipt through
brev exec --host.No environment was created, stopped, or deleted during this validation. The installed CLI was not replaced.
Validation
go run mvdan.cc/gofumpt -l -d -e ../pkg/cmd/refresh/sshaccess.go ../pkg/cmd/refresh/sshaccess_test.gogo test -race ./pkg/cmd/refreshgo test -race ./pkg/ssh -run '^(Test_makeSSHConfigEntryV2|TestCreateNewSSHConfig|TestCreateNewSSHConfig_WithNodes|TestCreateNewSSHConfig_WorkspacesAndNodes)$'go vet ./pkg/cmd/refreshgolangci-lint run ./pkg/cmd/refreshThe complete
pkg/sshtest package has existing macOS environment failures: JetBrains Gateway path tests require a local installation, andTestSSHConfigurerV2_Updateinvokes a WSL-only fixture. The platform-independent SSH configuration tests listed above pass.Related work
brev exec --host. This PR fixes the host endpoint corruption but does not close that broader issue.