fix(desktop): discover remote channel agents - #5084
Conversation
Co-authored-by: Rey Marques <rey.marques@highrisetalent.com> Signed-off-by: Rey Marques <rey.marques@highrisetalent.com>
|
Heads-up from a parallel investigation on #5363, in case it's useful here. The We opened #5483 with a data-layer fix: merge Not a claim that this PR is wrong — the two layers are compatible — just that the eligibility change alone may not be reproducibly verifiable against relay-published agents. Full analysis in #5363. |
|
Thanks feel free to close this item as needed. |
|
Cross-linking from #5483, and flagging a trust-model consequence I think is worth a second look before this lands. return (
candidate.isAgent !== true ||
candidate.isMember === true || // ← new
allowedAgentPubkeys.has(normalizePubkey(candidate.pubkey))
);
It also only reaches the composer: the DM picker ( Root cause we traced for #5363: Would you consider closing in favor of #5483? Maintainers' call — but I'd argue the membership bypass shouldn't land as-is either way. |
|
Thanks for the deeper analysis. I'm comfortable closing this PR in favor of #5483. |
Channel members that are agents now remain eligible for mention autocomplete even when the current desktop has no local managed-agent record or relay-directory metadata for them. This lets users mention agents hosted on another desktop without copying the agent's runtime, credentials, or configuration to the desktop they are currently using.
The existing invocability guard still hides a channel-member agent when relay metadata explicitly says that the current user cannot invoke it. A regression test covers admission of remote channel members alongside the existing exclusion tests.
Verification
🤖 Generated with Compound Engineering