Skip to content

Fix prod_whl_upload: use deploy key instead of github.token for cross-repo push to batfish/pybatfish - #175

Merged
dhalperi merged 4 commits into
masterfrom
copilot/fix-upload-prod-job
Aug 19, 2026
Merged

Fix prod_whl_upload: use deploy key instead of github.token for cross-repo push to batfish/pybatfish#175
dhalperi merged 4 commits into
masterfrom
copilot/fix-upload-prod-job

Conversation

Copilot AI commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

github.token is scoped to the workflow's own repository (batfish/docker). Adding permissions: contents: write has no effect on pushes to batfish/pybatfish — those require a PAT.

Changes

  • reusable-upload.yml: Declare PYBATFISH_GITHUB_TOKEN as a required secret input; use it for the actions/checkout of batfish/pybatfish (which also configures git credentials for the subsequent git push)
  • cross_version_test.yml: Thread PYBATFISH_GITHUB_TOKEN: ${{ secrets.PYBATFISH_GITHUB_TOKEN }} through the secrets: blocks of both upload_dev and upload_prod callers

Required action

Create a repository secret PYBATFISH_GITHUB_TOKEN in batfish/dockerSettings → Secrets → Actions containing a PAT with Contents: write on batfish/pybatfish.

@batfish-bot

Copy link
Copy Markdown

This change is Reviewable

Co-authored-by: dhalperi <526415+dhalperi@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing GitHub Actions job upload_prod / prod_whl_upload Fix prod_whl_upload: use PAT instead of github.token for cross-repo push to batfish/pybatfish Aug 19, 2026
Copilot AI requested a review from dhalperi August 19, 2026 11:51
Co-authored-by: dhalperi <526415+dhalperi@users.noreply.github.com>
Co-authored-by: dhalperi <526415+dhalperi@users.noreply.github.com>
@dhalperi dhalperi changed the title Fix prod_whl_upload: use PAT instead of github.token for cross-repo push to batfish/pybatfish Fix prod_whl_upload: use deploy key instead of github.token for cross-repo push to batfish/pybatfish Aug 19, 2026
@dhalperi
dhalperi marked this pull request as ready for review August 19, 2026 12:16
@dhalperi
dhalperi enabled auto-merge (squash) August 19, 2026 12:16

@dhalperi dhalperi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhalperi reviewed 2 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on copilot[bot]).

@dhalperi
dhalperi merged commit 7b03cea into master Aug 19, 2026
14 checks passed
@dhalperi
dhalperi deleted the copilot/fix-upload-prod-job branch August 19, 2026 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants