Fix prod_whl_upload: use deploy key instead of github.token for cross-repo push to batfish/pybatfish - #175
Merged
Merged
Conversation
Co-authored-by: dhalperi <526415+dhalperi@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job upload_prod / prod_whl_upload
Fix prod_whl_upload: use PAT instead of github.token for cross-repo push to batfish/pybatfish
Aug 19, 2026
Co-authored-by: dhalperi <526415+dhalperi@users.noreply.github.com>
Co-authored-by: dhalperi <526415+dhalperi@users.noreply.github.com>
dhalperi
marked this pull request as ready for review
August 19, 2026 12:16
dhalperi
enabled auto-merge (squash)
August 19, 2026 12:16
dhalperi
reviewed
Aug 19, 2026
dhalperi
left a comment
Member
There was a problem hiding this comment.
@dhalperi reviewed 2 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on copilot[bot]).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github.tokenis scoped to the workflow's own repository (batfish/docker). Addingpermissions: contents: writehas no effect on pushes tobatfish/pybatfish— those require a PAT.Changes
reusable-upload.yml: DeclarePYBATFISH_GITHUB_TOKENas a required secret input; use it for theactions/checkoutofbatfish/pybatfish(which also configures git credentials for the subsequentgit push)cross_version_test.yml: ThreadPYBATFISH_GITHUB_TOKEN: ${{ secrets.PYBATFISH_GITHUB_TOKEN }}through thesecrets:blocks of bothupload_devandupload_prodcallersRequired action
Create a repository secret
PYBATFISH_GITHUB_TOKENinbatfish/docker→ Settings → Secrets → Actions containing a PAT withContents: writeonbatfish/pybatfish.