Skip to content

Fix prod wheel upload checkout auth fallback - #174

Merged
dhalperi merged 5 commits into
masterfrom
copilot/fix-upload-prod-job
Aug 19, 2026
Merged

Fix prod wheel upload checkout auth fallback#174
dhalperi merged 5 commits into
masterfrom
copilot/fix-upload-prod-job

Conversation

Copilot AI commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

upload_prod / prod_whl_upload was failing during the pybatfish checkout step because the workflow supplied an empty explicit token instead of falling back to the default GitHub token. This change restores the intended auth behavior without reintroducing secret pass-through in the reusable workflow.

  • Root cause

    • actions/checkout in prod_whl_upload used OPEN_SOURCE_BUILDKITEBOT_PUBLIC_REPO_TOKEN directly.
    • When that secret was absent, checkout failed with Input required and not supplied: token instead of using the default workflow token.
  • Workflow auth behavior

    • Keep OPEN_SOURCE_BUILDKITEBOT_PUBLIC_REPO_TOKEN out of workflow_call secret plumbing.
    • Update the pybatfish checkout step to fall back to github.token:
token: ${{ secrets.OPEN_SOURCE_BUILDKITEBOT_PUBLIC_REPO_TOKEN || github.token }}
  • Scope
    • Remove the secret pass-through added in cross_version_test.yml.
    • Remove the corresponding required secret declaration from reusable-upload.yml.
    • Limit the change to the prod_whl_upload checkout path.

@batfish-bot

Copy link
Copy Markdown

This change is Reviewable

Copilot AI and others added 2 commits August 19, 2026 00:18
Co-authored-by: dhalperi <526415+dhalperi@users.noreply.github.com>
Co-authored-by: dhalperi <526415+dhalperi@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing GitHub Actions job upload_prod / prod_whl_upload Fix prod wheel upload checkout auth fallback Aug 19, 2026
Copilot AI requested a review from dhalperi August 19, 2026 00:21
Co-authored-by: dhalperi <526415+dhalperi@users.noreply.github.com>
@dhalperi
dhalperi marked this pull request as ready for review August 19, 2026 01:55

@dhalperi dhalperi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhalperi reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on copilot[bot]).

Co-authored-by: dhalperi <526415+dhalperi@users.noreply.github.com>

@dhalperi dhalperi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhalperi reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on copilot[bot]).

@dhalperi
dhalperi enabled auto-merge (squash) August 19, 2026 05:38
@dhalperi
dhalperi merged commit 72496d4 into master Aug 19, 2026
14 checks passed
@dhalperi
dhalperi deleted the copilot/fix-upload-prod-job branch August 19, 2026 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants