fix(b20): share activity history with the account demo - #94
Open
danyalprout wants to merge 1 commit into
Open
Conversation
B20 kept its own session-local, non-persisted activity list and never logged into the shared account engine's activity log, so token demo transactions never showed up in the account demo's history (and vice versa) even though both demos already share the same local accounts via localStorage. Route B20 sends through engine.pushActivity and render the shared ActivityLog component so both demos show one consistent, persisted trail. Co-Authored-By: Claude <noreply@anthropic.com>
Collaborator
🟡 Heimdall Review Status
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Tokens (b20) demo and the Accounts demo already share local EIP-8130 accounts via the same
localStorage-backeduseAccountEngine, but b20 kept its own session-local, non-persisted activity list instead of using the engine's shared activity log.