Use CRT response file for downloadFile in S3 TransferManager - #7230
Open
alextwoods wants to merge 1 commit into
Open
Use CRT response file for downloadFile in S3 TransferManager#7230alextwoods wants to merge 1 commit into
alextwoods wants to merge 1 commit into
Conversation
alextwoods
force-pushed
the
alexwoo/s3-crt-tm-download-to-file
branch
from
August 12, 2026 15:47
ae4b81b to
e336659
Compare
alextwoods
force-pushed
the
alexwoo/s3-crt-tm-download-to-file
branch
from
August 12, 2026 21:41
e336659 to
3b10f11
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use CRT response file for downloadFile in S3 TransferManager
Motivation and Context
We previously only added direct-download-to-file support from CRT to the low level S3 CRT client in #6289. This PR, extends that support to the S3 TransferManager now that pause/resume is natively supported by CRT (see: awslabs/aws-crt-java#1008).
Modifications
CrtFileDownload— aFileDownloadimplementation that pauses/resumes downloads where CRT writes the response body directly to a file (bypassingAsyncResponseTransformer)S3MetaRequestPauseObservable.pauseAsync()— an async pause API that waits for CRT to quiesce before returning the resume tokenCrtS3TransferManagerwithdoDownloadFileanddoResumeDownloadFilethat use CRT's direct-to-file path with pause/resume supportTransferProgressUpdater.crtProgressListener()andwrapCrtResponseFileTransformer()to track progress when the SDK never sees the response body bytesResumableRequestConverterwithtoCrtDownloadFileRequestto build ranged-GET resume requests from CRT resume tokensSdkClientExceptiononInterruptedExceptionduring pause (consistent with SDK convention) instead of silently swallowingTesting
New and existing unit and integration tests + manual testing.
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License