Skip to content

chore: update the async initial strategy plugin - #1264

Merged
karenc-bq merged 2 commits into
mainfrom
chore/initial-strategy-plugin-async
Aug 14, 2026
Merged

chore: update the async initial strategy plugin#1264
karenc-bq merged 2 commits into
mainfrom
chore/initial-strategy-plugin-async

Conversation

@karenc-bq

Copy link
Copy Markdown
Contributor

Description

Update the async initial strategy plugin

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.


Setting a value outside the valid set for the given endpoint raises an error.

> **Note:** `endpoint_substitution_role=any` is accepted only for a custom cluster endpoint, but host selection for the `any` role is not currently supported — it raises an unsupported-strategy error at connect time. Use `reader` or `none` for custom cluster endpoints.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this note to be quite confusing - it doesn't match the table and it seems to me that any is not supported

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any is accepted for custom cluster endpoints, but there are missing handling for this so while it is accepted it will still throw an exception. I will make a separate PR fixing this in impacted wrappers

Comment thread tests/unit/test_aio_aurora_initial_connection.py
Comment thread aws_advanced_python_wrapper/aio/aurora_initial_connection_strategy_plugin.py Outdated
Base automatically changed from chore/initial-strategy-plugin to main August 6, 2026 01:25
@karenc-bq
karenc-bq force-pushed the chore/initial-strategy-plugin-async branch from 30ea80a to 16070b5 Compare August 6, 2026 01:25
@karenc-bq
karenc-bq force-pushed the chore/initial-strategy-plugin-async branch from 16070b5 to 79bab77 Compare August 12, 2026 00:24
@karenc-bq
karenc-bq merged commit 689ead6 into main Aug 14, 2026
9 checks passed
@karenc-bq
karenc-bq deleted the chore/initial-strategy-plugin-async branch August 14, 2026 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants