refactor: align templates with old cli definition - #2094
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor #2094 +/- ##
=========================================
Coverage 97.36% 97.36%
=========================================
Files 410 410
Lines 24796 24819 +23
=========================================
+ Hits 24142 24165 +23
Misses 654 654 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
e6f99c9 to
4c16ba0
Compare
4c16ba0 to
4a80a21
Compare
| }, | ||
| }; | ||
|
|
||
| function buildRuntimeTemplateKey(input: ScaffoldRuntimeInput): string { |
There was a problem hiding this comment.
i plan to refactor this in a future PR. We're going to want some of these parameters to determine the asset templates to render from, and some of them to be rendered into it with handlebars. However, this felt like the smallest change I could make to keep it functional with the new interface.
This PR is intended to focus on aligning the handlers with what we want, then we work backwards from there to implement the functionality we need to support it.
Problem
The new CLI has a new definition of templates that is not fully flushed out and diverges from the old CLI. We want to get e2e functionality first, before rethinking this.
Solution
Future Work
Want to refactor the templates to split up template parameters from template identifiers (i.e. what determines the base vs rendered in with handlebars. )
Testing